LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Mark Lord <mlord@pobox.com>, Jeff Garzik <jeff@garzik.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure
Date: Wed, 13 Feb 2008 18:20:19 +0900 [thread overview]
Message-ID: <47B2B653.7020408@gmail.com> (raw)
In-Reply-To: <20080213090159.GA21614@elte.hu>
ata_host_detach() detaches an attached port and shouldn't be called on
a port which hasn't been attached yet. pata_legacy incorrectly calls
ata_host_detach() on unattached port after initialization failure
causing oops. Fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>
---
drivers/ata/pata_legacy.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
index 333dc15..7383f19 100644
--- a/drivers/ata/pata_legacy.c
+++ b/drivers/ata/pata_legacy.c
@@ -1278,8 +1278,6 @@ static __init int legacy_init_one(struct legacy_probe *probe)
}
}
fail:
- if (host)
- ata_host_detach(host);
platform_device_unregister(pdev);
return ret;
}
next prev parent reply other threads:[~2008-02-13 9:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 0:44 Linux 2.6.25-rc1 Linus Torvalds
2008-02-11 1:36 ` Sergio Luis
2008-02-11 1:47 ` Linux 2.6.25-rc1 , syntax error near unexpected token `;' Mr. James W. Laferriere
2008-02-11 7:02 ` Ray Lee
2008-02-11 13:29 ` [patch] " Oleg Verych
2008-02-11 13:26 ` Sam Ravnborg
2008-02-12 3:37 ` Mr. James W. Laferriere
2008-02-11 3:14 ` Linux 2.6.25-rc1 Gene Heskett
2008-02-11 7:39 ` Brice Goglin
2008-02-11 15:16 ` Arjan van de Ven
2008-02-11 11:19 ` parisc - error: 'VMALLOC_START' undeclared Domenico Andreoli
2008-02-11 12:06 ` Adrian Bunk
2008-02-11 13:31 ` Linux 2.6.25-rc1 Sam Ravnborg
2008-02-11 16:17 ` Mike Frysinger
2008-02-11 16:47 ` [PATCH] kbuild: fix make V=1 Sam Ravnborg
2008-02-11 23:38 ` Oleg Verych
2008-02-12 8:56 ` Sam Ravnborg
2008-02-12 9:25 ` Oleg Verych
2008-02-12 15:07 ` Mike Frysinger
2008-02-12 15:49 ` Oleg Verych
2008-02-12 16:18 ` Mike Frysinger
2008-02-12 16:42 ` Oleg Verych
2008-02-12 20:01 ` Sam Ravnborg
2008-02-11 21:46 ` Linux 2.6.25-rc1 Torsten Kaiser
2008-02-11 22:15 ` Andrew Morton
2008-02-11 22:48 ` Stefan Richter
2008-02-13 19:17 ` Torsten Kaiser
2008-02-12 8:18 ` [ata crash] " Ingo Molnar
2008-02-12 15:14 ` Arjan van de Ven
2008-02-13 9:01 ` Ingo Molnar
2008-02-13 9:20 ` Tejun Heo [this message]
2008-02-13 9:24 ` [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure Ingo Molnar
2008-02-15 18:52 ` Jeff Garzik
2008-02-13 9:51 ` [ata crash] Re: Linux 2.6.25-rc1 Tejun Heo
2008-02-21 2:33 ` Tejun Heo
2008-02-21 7:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B2B653.7020408@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mlord@pobox.com \
--cc=torvalds@linux-foundation.org \
--subject='Re: [libata-dev #upstream-fixes] pata_legacy: don'\''t call ata_host_detach() after initialization failure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).