LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [drivers/video/sis/init301.c] SiS_Pr->ChipType >= SIS_661 not evaluated twice
@ 2008-02-13 11:00 Roel Kluin
  0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2008-02-13 11:00 UTC (permalink / raw)
  To: thomas, lkml

Not sure whether this is important, but in drivers/video/sis/init301.c:1557:

  if((SiS_Pr->ChipType >= SIS_661) || (SiS_Pr->SiS_ROMNew)) {
     SiS_Pr->SiS_LCDTypeInfo = (SiS_GetReg(SiS_Pr->SiS_P3d4,0x39) & 0x7c) >> 2;
  } else if((SiS_Pr->ChipType < SIS_315H) || (SiS_Pr->ChipType >= SIS_661)) {
     SiS_Pr->SiS_LCDTypeInfo = temp >> 4;

note the duplicate test for 'SiS_Pr->ChipType >= SIS_661'
if it was true in the first test, the second test won't be evaluated.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-13 11:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-13 11:00 [drivers/video/sis/init301.c] SiS_Pr->ChipType >= SIS_661 not evaluated twice Roel Kluin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).