LKML Archive on
help / color / mirror / Atom feed
From: Avi Kivity <>
To: Sam Ravnborg <>
Cc: Olaf Hering <>,
Subject: Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
Date: Thu, 14 Feb 2008 11:27:40 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Sam Ravnborg wrote:
> On Wed, Feb 13, 2008 at 09:43:49AM +0200, Avi Kivity wrote:
>> Olaf Hering wrote:
>>>> Currently, make headers_check barfs due to <asm/kvm.h>, which 
>>>> <linux/kvm.h>
>>>> includes, not existing.  Rather than add a zillion <asm/kvm.h>s, export 
>>>> kvm.h
>>>> only if the arch actually supports it.
>>> This makes headers_install_all unreliable.
>>> linux/kvm.h will not be exported, depending on what system the libc
>>> headers will be generated. 
>> I see.  Any suggestions besides adding lots of asm-*/kvm.h?
> Do not include asm/kvm.h from linux/kvm.h.
> And in the few places where it is needed explicit include asm/kvm.h before
> linux/kvm.h.
> Alternatively inlcude asm/kvm.h inside #ifdef KERNEL"
> so only userspace has to do explicit include of asm before linux variant.

That's not very nice for userspace, which needs asm/kvm.h for the arch 
specific parts of the interface.  I'll add asm-*/kvm.h.

Any sufficiently difficult bug is indistinguishable from a feature.

  reply	other threads:[~2008-02-14  9:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10 11:15 Olaf Hering
2008-02-13  7:43 ` Avi Kivity
2008-02-13 20:34   ` Sam Ravnborg
2008-02-14  9:27     ` Avi Kivity [this message]
2008-03-13 11:13       ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).