LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
@ 2008-02-10 11:15 Olaf Hering
2008-02-13 7:43 ` Avi Kivity
0 siblings, 1 reply; 5+ messages in thread
From: Olaf Hering @ 2008-02-10 11:15 UTC (permalink / raw)
To: Avi Kivity, linux-kernel
> Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h>
> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h
> only if the arch actually supports it.
This makes headers_install_all unreliable.
linux/kvm.h will not be exported, depending on what system the libc
headers will be generated. Please revert
fb56dbb31c4738a3918db81fd24da732ce3b4ae6 and find a different way to run
make headers_check successfully.
Similar CONFIG_* usage is in include/asm-cris/Kbuild.
Fortunately, its not relevant in practice.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
2008-02-10 11:15 KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM Olaf Hering
@ 2008-02-13 7:43 ` Avi Kivity
2008-02-13 20:34 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Avi Kivity @ 2008-02-13 7:43 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-kernel, sam
Olaf Hering wrote:
>> Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h>
>> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h
>> only if the arch actually supports it.
>>
>
> This makes headers_install_all unreliable.
> linux/kvm.h will not be exported, depending on what system the libc
> headers will be generated.
I see. Any suggestions besides adding lots of asm-*/kvm.h?
--
Any sufficiently difficult bug is indistinguishable from a feature.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
2008-02-13 7:43 ` Avi Kivity
@ 2008-02-13 20:34 ` Sam Ravnborg
2008-02-14 9:27 ` Avi Kivity
0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2008-02-13 20:34 UTC (permalink / raw)
To: Avi Kivity; +Cc: Olaf Hering, linux-kernel
On Wed, Feb 13, 2008 at 09:43:49AM +0200, Avi Kivity wrote:
> Olaf Hering wrote:
> >>Currently, make headers_check barfs due to <asm/kvm.h>, which
> >><linux/kvm.h>
> >>includes, not existing. Rather than add a zillion <asm/kvm.h>s, export
> >>kvm.h
> >>only if the arch actually supports it.
> >>
> >
> >This makes headers_install_all unreliable.
> >linux/kvm.h will not be exported, depending on what system the libc
> >headers will be generated.
>
> I see. Any suggestions besides adding lots of asm-*/kvm.h?
Do not include asm/kvm.h from linux/kvm.h.
And in the few places where it is needed explicit include asm/kvm.h before
linux/kvm.h.
Alternatively inlcude asm/kvm.h inside #ifdef KERNEL"
so only userspace has to do explicit include of asm before linux variant.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
2008-02-13 20:34 ` Sam Ravnborg
@ 2008-02-14 9:27 ` Avi Kivity
2008-03-13 11:13 ` Olaf Hering
0 siblings, 1 reply; 5+ messages in thread
From: Avi Kivity @ 2008-02-14 9:27 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Olaf Hering, linux-kernel
Sam Ravnborg wrote:
> On Wed, Feb 13, 2008 at 09:43:49AM +0200, Avi Kivity wrote:
>
>> Olaf Hering wrote:
>>
>>>> Currently, make headers_check barfs due to <asm/kvm.h>, which
>>>> <linux/kvm.h>
>>>> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export
>>>> kvm.h
>>>> only if the arch actually supports it.
>>>>
>>>>
>>> This makes headers_install_all unreliable.
>>> linux/kvm.h will not be exported, depending on what system the libc
>>> headers will be generated.
>>>
>> I see. Any suggestions besides adding lots of asm-*/kvm.h?
>>
>
> Do not include asm/kvm.h from linux/kvm.h.
> And in the few places where it is needed explicit include asm/kvm.h before
> linux/kvm.h.
>
> Alternatively inlcude asm/kvm.h inside #ifdef KERNEL"
> so only userspace has to do explicit include of asm before linux variant.
>
That's not very nice for userspace, which needs asm/kvm.h for the arch
specific parts of the interface. I'll add asm-*/kvm.h.
--
Any sufficiently difficult bug is indistinguishable from a feature.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
2008-02-14 9:27 ` Avi Kivity
@ 2008-03-13 11:13 ` Olaf Hering
0 siblings, 0 replies; 5+ messages in thread
From: Olaf Hering @ 2008-03-13 11:13 UTC (permalink / raw)
To: Avi Kivity, Andrew Morton; +Cc: Sam Ravnborg, linux-kernel
On Thu, Feb 14, Avi Kivity wrote:
> Sam Ravnborg wrote:
>> On Wed, Feb 13, 2008 at 09:43:49AM +0200, Avi Kivity wrote:
>>
>>> Olaf Hering wrote:
>>>
>>>>> Currently, make headers_check barfs due to <asm/kvm.h>, which
>>>>> <linux/kvm.h>
>>>>> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export
>>>>> kvm.h
>>>>> only if the arch actually supports it.
>>>>>
>>>> This makes headers_install_all unreliable.
>>>> linux/kvm.h will not be exported, depending on what system the libc
>>>> headers will be generated.
>>> I see. Any suggestions besides adding lots of asm-*/kvm.h?
>>>
>>
>> Do not include asm/kvm.h from linux/kvm.h.
>> And in the few places where it is needed explicit include asm/kvm.h before
>> linux/kvm.h.
>>
>> Alternatively inlcude asm/kvm.h inside #ifdef KERNEL"
>> so only userspace has to do explicit include of asm before linux variant.
>>
>
> That's not very nice for userspace, which needs asm/kvm.h for the arch
> specific parts of the interface. I'll add asm-*/kvm.h.
Can you please revert this change before 2.6.25 is released?
'make headers_install_all' has to be reliable.
commit fb56dbb31c4738a3918db81fd24da732ce3b4ae6
Author: Avi Kivity <avi@qumranet.com>
Date: Sun Dec 2 10:50:06 2007 +0200
KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h>
includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h
only if the arch actually supports it.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-03-13 11:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-10 11:15 KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM Olaf Hering
2008-02-13 7:43 ` Avi Kivity
2008-02-13 20:34 ` Sam Ravnborg
2008-02-14 9:27 ` Avi Kivity
2008-03-13 11:13 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).