LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: "gdth: update deprecated pci_find_device" is incorrect
       [not found] <47B453D3.5060707@gmail.com>
@ 2008-02-14 14:47 ` Jiri Slaby
  2008-02-14 15:00   ` Jiri Slaby
  2008-02-14 15:02   ` Jiri Slaby
  0 siblings, 2 replies; 3+ messages in thread
From: Jiri Slaby @ 2008-02-14 14:47 UTC (permalink / raw)
  To: Sergio Luis
  Cc: James Bottomley, SCSI Mailing List, Jeff Garzik,
	Linux Kernel Mailing List

On 02/14/2008 03:44 PM, Jiri Slaby wrote:
> Hi,
> 
> commit
> 99109301d103fbf0de43fc5a580a406c12a501e0
> in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci 
> refcount on exit. Also you do not so on fail paths... I wonder why these 
> mistakes happen every second time somebody tries to do such change.
> 
> It leaked into mainline yet after "whole" two days, but what exactly 
> drives me crazy is, that Jeff commented it in similar way and nobody 
> reflected it!

BTW if you have more than one card, you protected the driver from no race, since 
you don't pci_dev_get of successfully grabbed cards.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: "gdth: update deprecated pci_find_device" is incorrect
  2008-02-14 14:47 ` "gdth: update deprecated pci_find_device" is incorrect Jiri Slaby
@ 2008-02-14 15:00   ` Jiri Slaby
  2008-02-14 15:02   ` Jiri Slaby
  1 sibling, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2008-02-14 15:00 UTC (permalink / raw)
  To: Jiri Slaby
  Cc: Sergio Luis, James Bottomley, SCSI Mailing List, Jeff Garzik,
	Linux Kernel Mailing List

On 02/14/2008 03:47 PM, Jiri Slaby wrote:
> On 02/14/2008 03:44 PM, Jiri Slaby wrote:
>> Hi,
>>
>> commit
>> 99109301d103fbf0de43fc5a580a406c12a501e0
>> in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci 
>> refcount on exit. Also you do not so on fail paths... I wonder why 
>> these mistakes happen every second time somebody tries to do such change.
>>
>> It leaked into mainline yet after "whole" two days, but what exactly 
>> drives me crazy is, that Jeff commented it in similar way and nobody 
>> reflected it!

Yeah, you did (I read the thread on wrong server obviusly), sorry...

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: "gdth: update deprecated pci_find_device" is incorrect
  2008-02-14 14:47 ` "gdth: update deprecated pci_find_device" is incorrect Jiri Slaby
  2008-02-14 15:00   ` Jiri Slaby
@ 2008-02-14 15:02   ` Jiri Slaby
  1 sibling, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2008-02-14 15:02 UTC (permalink / raw)
  To: Jiri Slaby
  Cc: Sergio Luis, James Bottomley, SCSI Mailing List, Jeff Garzik,
	Linux Kernel Mailing List

On 02/14/2008 03:47 PM, Jiri Slaby wrote:
> On 02/14/2008 03:44 PM, Jiri Slaby wrote:
>> commit
>> 99109301d103fbf0de43fc5a580a406c12a501e0
>> in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci 
[...]
> BTW if you have more than one card, you protected the driver from no 
> race, since you don't pci_dev_get of successfully grabbed cards.

(this still holds)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-14 15:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <47B453D3.5060707@gmail.com>
2008-02-14 14:47 ` "gdth: update deprecated pci_find_device" is incorrect Jiri Slaby
2008-02-14 15:00   ` Jiri Slaby
2008-02-14 15:02   ` Jiri Slaby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).