LKML Archive on
help / color / mirror / Atom feed
From: Masami Hiramatsu <>
To: Harvey Harrison <>
Cc: Ingo Molnar <>, Thomas Gleixner <>,
	"H. Peter Anvin" <>,
	LKML <>
Subject: Re: [PATCH] kprobes: remove sparse warnings from x86
Date: Thu, 14 Feb 2008 10:08:13 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1202945433.18204.28.camel@brick>

Harvey Harrison :
> arch/x86/kernel/kprobes.c:584:16: warning: symbol 'kretprobe_trampoline_holder' was not declared. Should it be static?
> arch/x86/kernel/kprobes.c:676:6: warning: symbol 'trampoline_handler' was not declared. Should it be static?
> Make them static and add the __used attribute, approach taken from the
> arm kprobes implementation.
> kretprobe_trampoline_holder uses inline assemly to define the global
> symbol kretprobe_trampoline, but nothing ever calls the holder explicitly.
> trampoline handler is only called from inline assembly in the same file,
> mark it used and static.
> Signed-off-by: Harvey Harrison <>

It looks good to me.

Acked-by: Masami Hiramatsu <>

Thank you,

Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division


  reply	other threads:[~2008-02-14 15:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 23:30 Harvey Harrison
2008-02-14 15:08 ` Masami Hiramatsu [this message]
2008-02-14 18:01   ` Harvey Harrison
2008-02-15  0:23     ` Ingo Molnar
2008-02-17 16:59     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] kprobes: remove sparse warnings from x86' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).