LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre Peiffer <pierre.peiffer@bull.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.24-mm1 0/8] (resend) IPC: code rewrite
Date: Fri, 15 Feb 2008 13:37:18 +0100	[thread overview]
Message-ID: <47B5877E.8050309@bull.net> (raw)
In-Reply-To: <p73y79mzcte.fsf@bingen.suse.de>



Andi Kleen wrote:
> pierre.peiffer@bull.net writes:
> 
>> 	This is a resend of the first part of the patchset sent 2 weeks
>> ago. This is the part about the IPC which (again) proposes to consolidate
>> some part of the existing code.
>>
>> 	It does not change the behavior of the existing code, but
>> improves it in term of readability and maintainability as it consolidates it
>> a little. As there was no objection, I think you can include them in your 
>> -mm tree.
>>
>> 	The patchset applies on top of "2.6.24-mm1 + previous patches about
>> IPC" sent the last days (ie Nadia's patches + mine).
> 
> While I have not read everything in detail from a quick overview
> the whole patch series looks like a nice and valuable cleanup to me.
> 
> I was a bit sceptical about all the interface enhancements your original
> patchkit had, but this one looks just fine.
> 

Thanks Andi for spending time on this review.
All kind of comments (positive or negative) are always welcome to make progress,
but of course, I particularly appreciate such positive feedbacks ;)

-- 
Pierre

      reply	other threads:[~2008-02-15 12:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 16:13 pierre.peiffer
2008-02-12 16:13 ` [PATCH 2.6.24-mm1 1/8] (resend) IPC/semaphores: code factorisation pierre.peiffer
2008-02-13 20:07   ` Alexey Dobriyan
2008-02-13 21:31     ` Pierre PEIFFER
2008-02-12 16:13 ` [PATCH 2.6.24-mm1 2/8] (resend) IPC/shared memory: introduce shmctl_down pierre.peiffer
2008-02-12 16:13 ` [PATCH 2.6.24-mm1 3/8] (resend) IPC/message queues: introduce msgctl_down pierre.peiffer
2008-02-12 16:13 ` [PATCH 2.6.24-mm1 4/8] (resend) IPC/semaphores: move the rwmutex handling inside semctl_down pierre.peiffer
2008-02-12 16:13 ` [PATCH 2.6.24-mm1 5/8] (resend) IPC/semaphores: remove one unused parameter from semctl_down() pierre.peiffer
2008-02-12 16:13 ` [PATCH 2.6.24-mm1 6/8] (resend) IPC: get rid of the use *_setbuf structure pierre.peiffer
2008-02-12 16:13 ` [PATCH 2.6.24-mm1 7/8] (resend) IPC: introduce ipc_update_perm() pierre.peiffer
2008-02-12 16:13 ` [PATCH 2.6.24-mm1 8/8] (resend) IPC: consolidate all xxxctl_down() functions pierre.peiffer
2008-03-05  0:03   ` Randy Dunlap
2008-02-15 11:19 ` [PATCH 2.6.24-mm1 0/8] (resend) IPC: code rewrite Andi Kleen
2008-02-15 12:37   ` Pierre Peiffer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B5877E.8050309@bull.net \
    --to=pierre.peiffer@bull.net \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 2.6.24-mm1 0/8] (resend) IPC: code rewrite' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).