LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Larry Woodman <lwoodman@redhat.com>
To: linux-kernel@vger.kernel.org
Subject: Problem with /proc/sys/vm/lowmem_reserve_ratio ???
Date: Fri, 15 Feb 2008 09:50:01 -0500 [thread overview]
Message-ID: <47B5A699.7010509@redhat.com> (raw)
balance_pgdat() calls zone_watermark_ok() three times, the first call
passes a zero(0) in as the 4th argument. This 4th argument is the
classzone_idx which is used as the index into the
zone->lowmem_reserve[] array. Since setup_per_zone_lowmem_reserve()
always sets the zone->lowmem_reserve[0] = 0(because there is nothing
below the DMA zone), zone_watermark_ok() will not consider the
lowmem_reserve pages when zero is passed as the 4th arg. Shouldnt this
4th argument be either "i" or "nr_zones - 1" ???
-------------------------------------------------------------------------
--- linux-2.6.24.noarch/mm/vmscan.c.orig 2008-02-13
11:14:55.000000000 -0500
+++ linux-2.6.24.noarch/mm/vmscan.c 2008-02-13 11:15:02.000000000
-0500
@@ -1375,7 +1375,7 @@ loop_again:
continue;
if (!zone_watermark_ok(zone, order, zone->pages_high,
- 0, 0)) {
+ i, 0)) {
end_zone = i;
break;
-------------------------------------------------------------------------
--- linux-2.6.24.noarch/mm/vmscan.c.orig 2008-02-13
11:14:55.000000000 -0500
+++ linux-2.6.24.noarch/mm/vmscan.c 2008-02-13 11:16:35.000000000
-0500
@@ -1375,7 +1375,7 @@ loop_again:
continue;
if (!zone_watermark_ok(zone, order, zone->pages_high,
- 0, 0)) {
+ nr_zones - 1, 0)) {
end_zone = i;
break;
}
-------------------------------------------------------------------------
next reply other threads:[~2008-02-15 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 14:50 Larry Woodman [this message]
2008-02-18 14:33 ` Jeff Moyer
2008-02-18 15:48 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B5A699.7010509@redhat.com \
--to=lwoodman@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: Problem with /proc/sys/vm/lowmem_reserve_ratio ???' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).