LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Sam Ravnborg <sam@ravnborg.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kkeil@suse.de,
	isdn4linux@listserv.isdn4linux.de, Greg KH <greg@kroah.com>
Subject: Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion
Date: Fri, 15 Feb 2008 10:13:43 -0500	[thread overview]
Message-ID: <47B5AC27.1030107@garzik.org> (raw)
In-Reply-To: <20080215132703.GG1178@uranus.ravnborg.org>

Sam Ravnborg wrote:
> On Tue, Jul 17, 2007 at 11:04:04PM -0400, Jeff Garzik wrote:
>> This is a refresh of an on-going work-in-progress:  convert the last
>> remaining users of pci_find_device() to the ISA/PCI/etc.  hotplug APIs
>> now in standard use.  After SCSI's gdth, ISDN's HiSax suite of drivers
>> are just about the last place using the older API.
>>
>> A few rough edges remain, and I'm not sure how much of ISDN userland
>> will explode (I have no ISDN hardware, nor much want any:)), but this
>> should get us almost all the way there.
>>
>> The patches are diff'd against 2.6.25-rc1.
>>
>> Comments/review/testing welcome.  Especially "it works" or "its dead"
>> testing.
> 
> Just ran checkpatch for the fun of it:
> total: 28 errors, 86 warnings, 4896 lines checked
> Most looks easy to fix.

I'll take a look...  if its checkpatch stuff I caused, I'm happy to fix it.

But I'm trying to avoid cleanups for pre-existing conditions, i.e. 
flagged by checkpatch only because I moved existing code to a new location.

Down that path lies madness and way too much work :)  I didn't sign on 
to clean up ISDN :)

Anyway, thanks for the multiple comments, they will be taken into 
account in the next update of these patches.

	Jeff



  reply	other threads:[~2008-02-15 15:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18  3:04 Jeff Garzik
2007-07-18  3:04 ` [PATCH 01/14] [ISDN] HiSax: modularize card setup Jeff Garzik
2008-02-15 13:38   ` Sam Ravnborg
2007-07-18  3:46 ` [PATCH 04/14] [ISDN] HiSax bkm_a4t: convert to PCI hotplug API Jeff Garzik
2008-02-15 13:33   ` Sam Ravnborg
2007-07-18  3:49 ` [PATCH 05/14] [ISDN] HiSax enternow: " Jeff Garzik
2008-02-15 13:21   ` Jan Engelhardt
2007-07-18  3:54 ` [PATCH 06/14] [ISDN] HiSax hfc_pci, w6692: " Jeff Garzik
2007-07-18  3:59 ` [PATCH 07/14] [ISDN] HiSax nj_s, nj_u: " Jeff Garzik
2007-07-18  4:02 ` [PATCH 08/14] [ISDN] HiSax telespci: " Jeff Garzik
2007-07-24 12:26 ` [PATCH 11/14] [ISDN] HiSax niccy: convert to modern ISA/PNP/PCI probing Jeff Garzik
2007-08-02 12:37 ` [PATCH 13/14] [ISDN] HiSax bkm_a8: convert to PCI hotplug API Jeff Garzik
2007-10-31  5:10 ` [PATCH 03/14] [ISDN] Ready HiSax driver for modularization Jeff Garzik
2008-02-15 13:45   ` Sam Ravnborg
2007-10-31  5:11 ` [PATCH 09/14] [ISDN] HiSax avm_pci: convert to modern PCI/ISA/PNP probing Jeff Garzik
2007-10-31  5:12 ` [PATCH 10/14] [ISDN] HiSax gazel: convert to modern ISA/PCI probing Jeff Garzik
2007-10-31  5:13 ` [PATCH 12/14] [ISDN] HiSax diva: convert to modern ISA/PNP/PCI probing Jeff Garzik
2007-10-31  7:42 ` [PATCH 02/14] [ISDN] Hisax: eliminate many unnecessary references to CardType[] Jeff Garzik
2008-02-15 13:37   ` Sam Ravnborg
2007-11-06 14:41 ` [PATCH 14/14] [isdn-pci] add missing file Jeff Garzik
2008-02-14 23:52 ` [PATCH 00/14] [ISDN] HiSax hotplug conversion Greg KH
2008-02-14 23:50   ` Jeff Garzik
2008-02-14 23:53 ` Jeff Garzik
2008-02-15 13:27 ` Sam Ravnborg
2008-02-15 15:13   ` Jeff Garzik [this message]
2008-02-15 19:11     ` Sam Ravnborg
2008-02-16  1:09 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B5AC27.1030107@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --subject='Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).