LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roel Kluin <12o3l@tiscali.nl>
To: geoffrey.levand@am.sony.com
Cc: linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org,
	lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] Fix Unlikely(x) == y
Date: Sat, 16 Feb 2008 17:08:01 +0100	[thread overview]
Message-ID: <47B70A61.9030306@tiscali.nl> (raw)

The patch below was not yet tested. If it's correct as it is, please comment.
---
Fix Unlikely(x) == y

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/powerpc/platforms/ps3/interrupt.c b/arch/powerpc/platforms/ps3/interrupt.c
index 3a6db04..a14e5cd 100644
--- a/arch/powerpc/platforms/ps3/interrupt.c
+++ b/arch/powerpc/platforms/ps3/interrupt.c
@@ -709,7 +709,7 @@ static unsigned int ps3_get_irq(void)
 	asm volatile("cntlzd %0,%1" : "=r" (plug) : "r" (x));
 	plug &= 0x3f;
 
-	if (unlikely(plug) == NO_IRQ) {
+	if (unlikely(plug == NO_IRQ)) {
 		pr_debug("%s:%d: no plug found: thread_id %lu\n", __func__,
 			__LINE__, pd->thread_id);
 		dump_bmp(&per_cpu(ps3_private, 0));

             reply	other threads:[~2008-02-16 16:08 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16 16:08 Roel Kluin [this message]
2008-02-16 17:25 ` Arjan van de Ven
2008-02-16 17:33   ` Willy Tarreau
2008-02-16 17:42     ` Arjan van de Ven
2008-02-16 17:58       ` Willy Tarreau
2008-02-16 18:29         ` Arjan van de Ven
2008-02-17  9:45         ` [Cbe-oss-dev] " Andrew Pinski
2008-02-17 10:08           ` Willy Tarreau
2008-02-16 18:31       ` Geoff Levand
2008-02-16 18:39         ` Arjan van de Ven
2008-02-17 11:50           ` Michael Ellerman
2008-02-18 13:56             ` Adrian Bunk
2008-02-18 14:01               ` Geert Uytterhoeven
2008-02-18 14:13                 ` Adrian Bunk
2008-02-18 21:46                   ` Michael Ellerman
2008-02-19  7:43                     ` Adrian Bunk
2008-02-18 19:22                 ` [Cbe-oss-dev] " Andrew Pinski
2008-02-18 14:27               ` David Howells
2008-02-18 14:59                 ` Roel Kluin
2008-02-18 18:11                 ` Valdis.Kletnieks
2008-02-18 18:33                   ` Arjan van de Ven
2008-02-18 14:39       ` Andi Kleen
2008-02-19  2:33         ` Nick Piggin
2008-02-19  2:40           ` Arjan van de Ven
2008-02-19  4:41             ` Nick Piggin
2008-02-19  5:58           ` Willy Tarreau
2008-02-19  6:20             ` Nick Piggin
2008-02-19  9:28             ` Andi Kleen
2008-02-20  7:32               ` Willy Tarreau
2008-02-19  9:25           ` Andi Kleen
2008-02-19  9:46             ` Nick Piggin
2008-02-19  9:57               ` Andi Kleen
2008-02-19 22:25                 ` Nick Piggin
2008-02-16 18:41 ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B70A61.9030306@tiscali.nl \
    --to=12o3l@tiscali.nl \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=geoffrey.levand@am.sony.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --subject='Re: [PATCH 1/3] Fix Unlikely(x) == y' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).