LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Paulo Marques <pmarques@grupopie.com>
Cc: Theodore Tso <tytso@mit.edu>, Andi Kleen <andi@firstfloor.org>,
	Tomasz Chmielewski <mangoo@wpkg.org>,
	LKML <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: very poor ext3 write performance on big filesystems?
Date: Tue, 19 Feb 2008 17:33:50 -0500	[thread overview]
Message-ID: <47BB594E.1050103@rtr.ca> (raw)
In-Reply-To: <47BB26CB.8010705@grupopie.com>

Paulo Marques wrote:
> Mark Lord wrote:
>> Theodore Tso wrote:
>> ..
>>> The following ld_preload can help in some cases.  Mutt has this hack
>>> encoded in for maildir directories, which helps.
>> ..
>>
>> Oddly enough, that same spd_readdir() preload craps out here too
>> when used with "rm -r" on largish directories.
> 
>  From looking at the code, I think I've found at least one bug in opendir:
> ...
>>             dnew = realloc(dirstruct->dp,                        
>> dirstruct->max * sizeof(struct dir_s));
> ...
> 
> Shouldn't this be: "...*sizeof(struct dirent_s));"?
..

Yeah, that's one bug.
Another is that ->fd is frequently left uninitialized, yet later used.

Fixing those didn't change the null pointer deaths, though.



  reply	other threads:[~2008-02-19 22:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 12:57 Tomasz Chmielewski
2008-02-18 14:03 ` Andi Kleen
2008-02-18 14:16   ` Theodore Tso
2008-02-18 15:02     ` Tomasz Chmielewski
2008-02-18 15:16       ` Theodore Tso
2008-02-18 15:57         ` Andi Kleen
2008-02-18 15:35           ` Theodore Tso
2008-02-20 10:57             ` Jan Engelhardt
2008-02-20 17:44               ` David Rees
2008-02-20 18:08                 ` Jan Engelhardt
2008-02-18 16:16         ` Tomasz Chmielewski
2008-02-18 18:45           ` Theodore Tso
2008-02-18 15:18     ` Andi Kleen
2008-02-18 15:03       ` Theodore Tso
2008-02-19 14:54     ` Tomasz Chmielewski
2008-02-19 15:06       ` Chris Mason
2008-02-19 15:21         ` Tomasz Chmielewski
2008-02-19 16:04           ` Chris Mason
2008-02-19 18:29     ` Mark Lord
2008-02-19 18:41       ` Mark Lord
2008-02-19 18:58       ` Paulo Marques
2008-02-19 22:33         ` Mark Lord [this message]
2008-02-27 11:20     ` Tomasz Chmielewski
2008-02-27 20:03       ` Andreas Dilger
2008-02-27 20:25         ` Tomasz Chmielewski
2008-03-01 20:04         ` Bill Davidsen
2008-02-19  9:24 ` Vladislav Bolkhovitin
     [not found] <9YdLC-75W-51@gated-at.bofh.it>
     [not found] ` <9YeRh-Gq-39@gated-at.bofh.it>
     [not found]   ` <9Yf0W-SX-19@gated-at.bofh.it>
     [not found]     ` <9YfNi-2da-23@gated-at.bofh.it>
     [not found]       ` <9YfWL-2pZ-1@gated-at.bofh.it>
     [not found]         ` <9Yg6H-2DJ-23@gated-at.bofh.it>
2008-02-19 13:14           ` Paul Slootman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BB594E.1050103@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=andi@firstfloor.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mangoo@wpkg.org \
    --cc=pmarques@grupopie.com \
    --cc=tytso@mit.edu \
    --subject='Re: very poor ext3 write performance on big filesystems?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).