LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
	kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] build #365 issue for v2.6.25-rc2-342-g5d9c4a7 in ./arch/x86/kvm/kvm.ko
Date: Wed, 20 Feb 2008 16:07:03 +0200	[thread overview]
Message-ID: <47BC3407.20307@qumranet.com> (raw)
In-Reply-To: <47BC3121.8070902@qumranet.com>

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Avi Kivity wrote:
> Toralf Förster wrote:
>> Hello,
>>
>> the build with the attached .config failed, make ends with:
>> ...
>>   HOSTCC  arch/x86/boot/tools/build
>>   BUILD   arch/x86/boot/bzImage
>> Root device is (3, 8)
>> Setup is 12280 bytes (padded to 12288 bytes).
>> System is 2192 kB
>> Kernel: arch/x86/boot/bzImage is ready  (#1)
>>   Building modules, stage 2.
>>   MODPOST 211 modules
>> ERROR: "smp_ops" [arch/x86/kvm/kvm.ko] undefined!
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>>
>>
>> The build was made with :
>> $> make mrproper && make rndconfig && <tweak config file> && make 
>> oldconfig && make
>>
>> Here's the config:
>>   
>
> Looks like KVM conflicts with CONFIG_VOYAGER...
>

Attached patch should fix.

Subject: x86: disable KVM on Voyager

Most classic Pentiums don't have hardware virtualization
extension, and building kvm with voyager generates
spurious failures.

Signed-off-by: Avi Kivity <avi@qumranet.com>

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


[-- Attachment #2: kvm-vs-voyager.patch --]
[-- Type: text/x-patch, Size: 323 bytes --]

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index cc2bc37..e27962c 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -21,7 +21,7 @@ config X86
 	select HAVE_IDE
 	select HAVE_OPROFILE
 	select HAVE_KPROBES
-	select HAVE_KVM
+	select HAVE_KVM if ((X86_32 && !X86_VOYAGER) || X86_64)
 
 
 config GENERIC_LOCKBREAK

  reply	other threads:[~2008-02-20 14:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 13:11 Toralf Förster
2008-02-20 13:54 ` [kvm-devel] " Avi Kivity
2008-02-20 14:07   ` Avi Kivity [this message]
2008-02-20 17:20     ` [PATCH] " Randy Dunlap
2008-02-25 23:03       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BC3407.20307@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=toralf.foerster@gmx.de \
    --subject='Re: [kvm-devel] build #365 issue for v2.6.25-rc2-342-g5d9c4a7 in ./arch/x86/kvm/kvm.ko' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).