LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2/2] firmware: fix a few build errors
@ 2008-02-20 21:21 Randy Dunlap
  2008-02-20 21:49 ` Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-02-20 21:21 UTC (permalink / raw)
  To: lkml; +Cc: gregkh, akpm

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix one typo (comma to semi-colon).
Fix sysfs externs (just use sysfs.h for prototypes).

Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file'
include/linux/sysfs.h:100: error: previous declaration of 'sysfs_remove_bin_file' was here

Still has a build error:
ERROR: "firmware_class" [samples/firmware_class/firmware_sample_firmware_class.ko]
undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 samples/firmware_class/firmware_sample_firmware_class.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- linux-2625-rc2-docsrc.orig/samples/firmware_class/firmware_sample_firmware_class.c
+++ linux-2625-rc2-docsrc/samples/firmware_class/firmware_sample_firmware_class.c
@@ -33,9 +33,6 @@ struct class_device_attribute *to_class_
 	return container_of(_attr,struct class_device_attribute,attr);
 }
 
-int sysfs_create_bin_file(struct kobject * kobj, struct bin_attribute * attr);
-int sysfs_remove_bin_file(struct kobject * kobj, struct bin_attribute * attr);
-
 struct firmware_priv {
 	char fw_id[FIRMWARE_NAME_MAX];
 	s32 loading:2;
@@ -127,7 +124,7 @@ static int fw_setup_class_device(struct 
 	class_dev->class_id[BUS_ID_SIZE-1] = '\0';
 	class_dev->dev = device;
 
-	class_dev->class = &firmware_class,
+	class_dev->class = &firmware_class;
 	class_set_devdata(class_dev, fw_priv);
 	retval = class_device_register(class_dev);
 	if (retval){

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] firmware: fix a few build errors
  2008-02-20 21:21 [PATCH 2/2] firmware: fix a few build errors Randy Dunlap
@ 2008-02-20 21:49 ` Marcel Holtmann
  2008-02-20 21:56   ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2008-02-20 21:49 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: lkml, gregkh, akpm

Hi Randy,

> Fix one typo (comma to semi-colon).
> Fix sysfs externs (just use sysfs.h for prototypes).
>
> Documentation/firmware_class/firmware_sample_firmware_class.c:37:  
> error: conflicting types for 'sysfs_remove_bin_file'
> include/linux/sysfs.h:100: error: previous declaration of  
> 'sysfs_remove_bin_file' was here
>
> Still has a build error:
> ERROR: "firmware_class" [samples/firmware_class/ 
> firmware_sample_firmware_class.ko]
> undefined!

while you are at it, can you also fix the broken coding style in it?

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] firmware: fix a few build errors
  2008-02-20 21:49 ` Marcel Holtmann
@ 2008-02-20 21:56   ` Randy Dunlap
  0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2008-02-20 21:56 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: lkml, gregkh, akpm

Marcel Holtmann wrote:
> Hi Randy,
> 
>> Fix one typo (comma to semi-colon).
>> Fix sysfs externs (just use sysfs.h for prototypes).
>>
>> Documentation/firmware_class/firmware_sample_firmware_class.c:37: 
>> error: conflicting types for 'sysfs_remove_bin_file'
>> include/linux/sysfs.h:100: error: previous declaration of 
>> 'sysfs_remove_bin_file' was here
>>
>> Still has a build error:
>> ERROR: "firmware_class" 
>> [samples/firmware_class/firmware_sample_firmware_class.ko]
>> undefined!
> 
> while you are at it, can you also fix the broken coding style in it?

Greg will do that while he is fixing the <firmware_class> data build error. :)

-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-20 21:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-20 21:21 [PATCH 2/2] firmware: fix a few build errors Randy Dunlap
2008-02-20 21:49 ` Marcel Holtmann
2008-02-20 21:56   ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).