LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] fs: removing unused fops from struct char_device_struct
@ 2008-02-20 20:57 Jiri Olsa
  2008-02-21  0:15 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Jiri Olsa @ 2008-02-20 20:57 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, kernel-janitors

Hi,

seems struct char_device_struct::fops is no longer used, removing it.
I checked with "make allyesconfig" and got proper compile.

Signed-off-by: Jiri Olsa <olsajiri@gmail.com>
---
 fs/char_dev.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/char_dev.c b/fs/char_dev.c
index c3bfa76..e4527fb 100644
--- a/fs/char_dev.c
+++ b/fs/char_dev.c
@@ -55,7 +55,6 @@ static struct char_device_struct {
 	unsigned int baseminor;
 	int minorct;
 	char name[64];
-	struct file_operations *fops;
 	struct cdev *cdev;		/* will die */
 } *chrdevs[CHRDEV_MAJOR_HASH_SIZE];
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fs: removing unused fops from struct char_device_struct
  2008-02-20 20:57 [PATCH] fs: removing unused fops from struct char_device_struct Jiri Olsa
@ 2008-02-21  0:15 ` Greg KH
  2008-02-21  6:08   ` Jiri Olsa
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2008-02-21  0:15 UTC (permalink / raw)
  To: Jiri Olsa; +Cc: gregkh, linux-kernel, kernel-janitors

On Wed, Feb 20, 2008 at 09:57:23PM +0100, Jiri Olsa wrote:
> Hi,
> 
> seems struct char_device_struct::fops is no longer used, removing it.
> I checked with "make allyesconfig" and got proper compile.
> 
> Signed-off-by: Jiri Olsa <olsajiri@gmail.com>

Hm, why send this to me?

Did I make the mistake of touching this file last?  Hm, nope, someone
else touched it after I did, I'm safe :)

Seriously, I have no problem with this, but it should probably go
through Andrew.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fs: removing unused fops from struct char_device_struct
  2008-02-21  0:15 ` Greg KH
@ 2008-02-21  6:08   ` Jiri Olsa
  0 siblings, 0 replies; 3+ messages in thread
From: Jiri Olsa @ 2008-02-21  6:08 UTC (permalink / raw)
  To: Greg KH; +Cc: gregkh, linux-kernel, kernel-janitors

oops, sorry... for some reason I though you were the guy :)
I'll resend

jirka


Greg KH wrote:
> On Wed, Feb 20, 2008 at 09:57:23PM +0100, Jiri Olsa wrote:
>> Hi,
>>
>> seems struct char_device_struct::fops is no longer used, removing it.
>> I checked with "make allyesconfig" and got proper compile.
>>
>> Signed-off-by: Jiri Olsa <olsajiri@gmail.com>
> 
> Hm, why send this to me?
> 
> Did I make the mistake of touching this file last?  Hm, nope, someone
> else touched it after I did, I'm safe :)
> 
> Seriously, I have no problem with this, but it should probably go
> through Andrew.
> 
> thanks,
> 
> greg k-h
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-21  6:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-20 20:57 [PATCH] fs: removing unused fops from struct char_device_struct Jiri Olsa
2008-02-21  0:15 ` Greg KH
2008-02-21  6:08   ` Jiri Olsa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).