LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Newall <davidn@davidnewall.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Greg KH <greg@kroah.com>,
linux-usb@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Handshaking on USB serial devices
Date: Fri, 22 Feb 2008 06:05:09 +1030 [thread overview]
Message-ID: <47BDD26D.5010004@davidnewall.com> (raw)
In-Reply-To: <20080221151549.0fa72422@core>
Alan Cox wrote:
>> developing is entirely wrong. Oh well. Mind you, providing a
>> write_room function is NOT a real solution; it merely reduces the
>> condition to a usually-winnable race. (Ironically, when I back-ported
>> the 2.6 driver, I excluded its new write_room function. Mistake.)
>>
>
> What race do you see left ?
>
On second thoughts I'm not sure that I do. I've had my head so full of
2.4 pl2303, and 2.4 pl2303 with this, that and the other added to it,
that I was probably just confused. Certainly it's not important,
because I didn't mean the 2.6 driver, but an hypothetical 2.4 with a
simplistic write_room function added (e.g. return
port->write_urb->status == -EINPROGRESS ? 0 : 64). OPOST processing's
use of putchar to expand CRLF sends two writes (or putchars), with no
intervening checks. Since I'm just polishing off my back-port of
2.6.24.1 pl2303 to kernel 2.4, the matter is quite irrelevant.
By the way, what happened to HUawei E620 UMTS/HSDPA card? It's in
pl2303 in 2.6.23; not in 2.6.24.1. (Do I remove it from my back-port?)
next prev parent reply other threads:[~2008-02-21 19:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 14:45 David Newall
2008-02-14 5:02 ` Greg KH
2008-02-14 9:25 ` David Newall
2008-02-14 12:10 ` Alan Cox
2008-02-14 16:16 ` Gene Heskett
2008-02-14 16:31 ` Alan Cox
2008-02-14 17:55 ` Gene Heskett
2008-02-14 19:37 ` Alan Cox
2008-02-14 20:04 ` Gene Heskett
2008-02-14 20:52 ` Greg KH
2008-02-14 21:32 ` Gene Heskett
2008-02-15 5:08 ` David Newall
2008-02-14 22:39 ` Krzysztof Halasa
2008-02-14 23:09 ` Gene Heskett
2008-02-14 18:04 ` David Newall
2008-02-14 18:53 ` David Brownell
2008-02-14 19:36 ` Alan Cox
2008-02-21 15:22 ` David Newall
2008-02-21 15:15 ` Alan Cox
2008-02-21 19:35 ` David Newall [this message]
2008-02-21 20:58 ` Greg KH
2008-02-14 20:47 ` Greg KH
2008-02-15 5:19 ` David Newall
2008-02-14 11:55 ` Alan Cox
[not found] <9Wr5Z-7cw-1@gated-at.bofh.it>
[not found] ` <9WSJ4-222-21@gated-at.bofh.it>
[not found] ` <9WTlN-2T0-7@gated-at.bofh.it>
[not found] ` <9WTYn-3Zb-29@gated-at.bofh.it>
2008-02-15 12:00 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BDD26D.5010004@davidnewall.com \
--to=davidn@davidnewall.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--subject='Re: Handshaking on USB serial devices' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).