LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
	linuxppc-dev@ozlabs.org, Kristian Hoegsberg <krh@bitplanet.net>,
	Jarod Wilson <jwilson@redhat.com>
Subject: Re: [PATCH 1/2] firewire: endianess fix
Date: Sat, 23 Feb 2008 13:12:32 +0100	[thread overview]
Message-ID: <47C00DB0.20605@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.9e19fa31951506af@s5r6.in-berlin.de>

I wrote:
> This needs to be tested on different big endian PCs, if possible with
> the Apple Uninorth FireWire controller and other types of controllers.
> One test which involves ohci->request_generation is simply with an SBP-2
> device (harddisk, CD-ROM...).  Does SBP-2 login etc. work?

Hmm, no, tests with SBP-2 devices won't trigger that problem at all.
All of the requests from the device will be:
   - read requests to the host's config ROM, handled by the controller's
     physical response unit instead of the driver stack's response
     handlers,
   - read requests to ORBs and read and write requests to SCSI data
     buffers which are DMA-mapped at bus addresses below 4G, hence be
     handled by the physical response unit as well,
   - write requests to firewire-sbp2's status FIFO which is mapped into
     a FireWire address range for which PCI write posting is enabled,
     hence no response subaction will be generated (unified transaction)
     and therefore ohci->request_generation remain unused.

Alas I have no idea how to create a simple test setup which really 
triggers the questionable code.  Or wait, it should be triggered by 
replacing
	&fw_high_memory_region
by
	&fw_private_region
in drivers/firewire/fw-sbp2.c and testing with any SBP-2 device which is 
_not_ based on the PL3507 bridge chip.  This moves the status FIFO into 
an area outside of PCI write posting and forces the driver stack to 
generate response packets.  (Some PL-3507 only accept unified 
transactions, hence this test needs to be performed with other bridge 
chips.)
-- 
Stefan Richter
-=====-==--- --=- =-===
http://arcgraph.de/sr/

  parent reply	other threads:[~2008-02-23 12:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 22:03 sparse - make __CHECK_ENDIAN__ default enabled? Sam Ravnborg
2008-02-20 22:18 ` Harvey Harrison
2008-02-23 11:23   ` [PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?) Stefan Richter
2008-02-23 11:24     ` [PATCH 1/2] firewire: endianess fix Stefan Richter
2008-02-23 11:36       ` Stefan Richter
2008-02-23 12:12       ` Stefan Richter [this message]
2008-03-01 12:36         ` Stefan Richter
2008-02-27 19:58       ` Jarod Wilson
2008-02-27 20:08         ` Stefan Richter
2008-02-27 20:21           ` Jarod Wilson
2008-02-28  2:40         ` Benjamin Herrenschmidt
2008-02-28  3:21           ` Jarod Wilson
2008-02-28  6:25             ` Benjamin Herrenschmidt
2008-02-28 18:42               ` Jarod Wilson
2008-02-28 23:26                 ` Benjamin Herrenschmidt
2008-02-29  5:48                   ` Jarod Wilson
2008-02-29  6:00                     ` Benjamin Herrenschmidt
2008-02-29 11:26                     ` Paul Mackerras
2008-02-29 11:52                       ` Stefan Richter
2008-02-29 21:49                         ` Benjamin Herrenschmidt
2008-02-29 15:34                       ` Jarod Wilson
2008-03-03  9:19                     ` Gabriel Paubert
2008-03-03 14:35                       ` Stefan Richter
2008-03-05 22:59                         ` Gabriel Paubert
2008-03-05 23:26                           ` Stefan Richter
2008-03-06 20:23                             ` Gabriel Paubert
2008-02-28  3:33         ` Jarod Wilson
2008-02-28  2:41       ` Benjamin Herrenschmidt
2008-02-28  8:41         ` Stefan Richter
2008-02-23 11:24     ` [PATCH 2/2] firewire: endianess annotations Stefan Richter
2008-03-01  5:23     ` [PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?) Jarod Wilson
2008-02-20 22:39 ` sparse - make __CHECK_ENDIAN__ default enabled? Harvey Harrison
2008-02-20 22:51   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C00DB0.20605@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=harvey.harrison@gmail.com \
    --cc=jwilson@redhat.com \
    --cc=krh@bitplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    --subject='Re: [PATCH 1/2] firewire: endianess fix' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).