LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Larry Finger <larry.finger@lwfinger.net>
To: Alexey Zaytsev <alexey.zaytsev@gmail.com>
Cc: Stefano Brivio <stefano.brivio@polimi.it>,
	Jeff Garzik <jgarzik@pobox.com>, Greg KH <greg@kroah.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Ingo Molnar <mingo@elte.hu>, Michael Buesch <mb@bu3sch.de>,
	linux-kernel@vger.kernel.org,
	John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
Date: Sun, 24 Feb 2008 09:26:34 -0700	[thread overview]
Message-ID: <47C19ABA.4040904@lwfinger.net> (raw)
In-Reply-To: <47C01D03.9030601@gmail.com>

Alexey Zaytsev wrote:
> 
> [resent with lkml added to cc, sorry]
> 
> Hello, gentlemen.
> 
> Theese two patches fix a problem instroduced in Linux 2.6.24, and
> still present in the current Linus' 2.6.25 tree.
> 
> The bcm43xx Wifi driver won't work any more, if the b44 Ethernet
> driver is enabled. This happens because the b44 driver
> needlessly enables the b43_pci_bridge code, which claims
> the same pci ids as the bcm43xx driver. The b43_pci_bridge
> code is needed for the b43{legacy} drivers, but for the
> b44, only the "ssb pci core" is needed.
> 
> The first patch separates the ssb b43 pci bridge and the ssb pci
> core config options and enables only the needed ones.
> 
> A similar patch was once sent to Michael Buesch, but he rejected
> it, fearing that changing the config autoselects cold introduce
> some unexpected bugs.
> If you are intrested, a rather emotional thread may be found
> e.g. here:
> http://thread.gmane.org/gmane.linux.kernel/644266
> 
> That said, I believe the patch may introduce no more bugs,
> but fixes a critical regression, which left some users
> without a working wifi driver on the 2.6.24 kernel.
> 
> If you doubt its correctness, I may write a longer description
> on the changes introduced, but I hope they should be obvoius.
> 
> This patch is againts the current Linus' tree. I'd like it
> to be added to both 2.6.25 and the 2.6.24-stable trees.
> 
> The second patch disables the bcm43xx driver if it can't
> work due to the b43/b43legacy drivers inclusion, so no
> users should be confused.

I have reviewed the above patches and tested them with what I believe to be most combinations. 
Everything worked and corrected the unintended consequence of breaking bcm43xx when b44 is included. 
I agree that these patches belong in 2.6.25 and stable (2.6.24). Of course, the problem goes away in 
2.6.26.

ACKED-by: Larry.Finger@lwfinger.net

Larry


  parent reply	other threads:[~2008-02-24 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23 13:17 Alexey Zaytsev
2008-02-23 16:20 ` Michael Buesch
2008-02-23 20:37   ` Alexey Zaytsev
2008-02-24 16:26 ` Larry Finger [this message]
2008-02-27 20:15   ` John W. Linville
2008-02-27 21:58     ` Michael Buesch
2008-02-28  1:15       ` John W. Linville
2008-02-29  8:21 ` Andrew Morton
2008-02-29 10:05   ` Michael Buesch
2008-02-29 20:54     ` Ingo Molnar
2008-02-29 22:49       ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C19ABA.4040904@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=alexey.zaytsev@gmail.com \
    --cc=greg@kroah.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=stefano.brivio@polimi.it \
    --subject='Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).