LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ps3: Fix "unlikely" incorrect usage
@ 2008-02-24 8:06 Samuel Tardieu
2008-02-24 18:49 ` Geoff Levand
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Tardieu @ 2008-02-24 8:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Geoff Levand, linuxppc-dev, cbe-oss-dev
Fix unlikely(plug) == NO_IRQ into unlikely(plug == NO_IRQ).
Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
---
arch/powerpc/platforms/ps3/interrupt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/ps3/interrupt.c b/arch/powerpc/platforms/ps3/interrupt.c
index 3a6db04..a14e5cd 100644
--- a/arch/powerpc/platforms/ps3/interrupt.c
+++ b/arch/powerpc/platforms/ps3/interrupt.c
@@ -709,7 +709,7 @@ static unsigned int ps3_get_irq(void)
asm volatile("cntlzd %0,%1" : "=r" (plug) : "r" (x));
plug &= 0x3f;
- if (unlikely(plug) == NO_IRQ) {
+ if (unlikely(plug == NO_IRQ)) {
pr_debug("%s:%d: no plug found: thread_id %lu\n", __func__,
__LINE__, pd->thread_id);
dump_bmp(&per_cpu(ps3_private, 0));
--
1.5.4.2.197.g22c43
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ps3: Fix "unlikely" incorrect usage
2008-02-24 8:06 [PATCH] ps3: Fix "unlikely" incorrect usage Samuel Tardieu
@ 2008-02-24 18:49 ` Geoff Levand
0 siblings, 0 replies; 2+ messages in thread
From: Geoff Levand @ 2008-02-24 18:49 UTC (permalink / raw)
To: Samuel Tardieu; +Cc: linux-kernel, linuxppc-dev, cbe-oss-dev
On 02/24/2008 12:06 AM, Samuel Tardieu wrote:
> Fix unlikely(plug) == NO_IRQ into unlikely(plug == NO_IRQ).
>
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
> ---
> arch/powerpc/platforms/ps3/interrupt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks for the submission, but this fix is already in
ps3-linux.git. I was waiting to collect a few other bugs
before sending it to Paul.
-Geoff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-24 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-24 8:06 [PATCH] ps3: Fix "unlikely" incorrect usage Samuel Tardieu
2008-02-24 18:49 ` Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).