LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Max Krasnyanskiy <maxk@qualcomm.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC] Genirq and CPU isolation
Date: Mon, 25 Feb 2008 10:34:56 -0800	[thread overview]
Message-ID: <47C30A50.5010709@qualcomm.com> (raw)
In-Reply-To: <20080224174727.1a3f4dd7.randy.dunlap@oracle.com>

Randy Dunlap wrote:
> On Fri, 22 Feb 2008 22:19:18 -0800 Max Krasnyansky wrote:
> 
> Hi Max,
> 
>> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
>> index 438a014..e74db94 100644
>> --- a/kernel/irq/manage.c
>> +++ b/kernel/irq/manage.c
>> @@ -488,6 +491,26 @@ void free_irq(unsigned int irq, void *dev_id)
>>  }
>>  EXPORT_SYMBOL(free_irq);
>>  
>> +#ifndef CONFIG_AUTO_IRQ_AFFINITY
>> +/**
>> + * Generic version of the affinity autoselector.
>> + * Called under desc->lock from setup_irq().
>> + * btw Should we rename this to select_irq_affinity() ?
>> + */
> 
> Please don't begin comment blocks with "/**" unless they are in
> kernel-doc format.  (See Documentation/kernel-doc-nano-HOWTO.txt
> for details of it.)
My bad. Cut & pasted another function and forgot to nuke one asterisk.

Thanx for the review Randy.
Max

  reply	other threads:[~2008-02-25 18:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23  6:19 Max Krasnyansky
2008-02-25  1:47 ` Randy Dunlap
2008-02-25 18:34   ` Max Krasnyanskiy [this message]
2008-02-27 20:41 ` Max Krasnyanskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C30A50.5010709@qualcomm.com \
    --to=maxk@qualcomm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [RFC] Genirq and CPU isolation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).