LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: "Michael S. Tsirkin" <m.s.tsirkin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Len Brown <len.brown@intel.com>,
	linux-acpi@vger.kernel.org
Subject: Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
Date: Tue, 26 Feb 2008 01:33:42 +0300	[thread overview]
Message-ID: <47C34246.2020705@suse.de> (raw)
In-Reply-To: <8f53421d0802251301g247506e9jb341b9012dac71d7@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

Michael S. Tsirkin wrote:
> On Mon, Feb 25, 2008 at 10:50 PM, Alexey Starikovskiy
> <astarikovskiy@suse.de> wrote:
>> Michael S. Tsirkin wrote:
>>  > Did you guys stop accepting reports by mail?
>>  > I hope not.
>>  It is easier to track bug information in bugzilla.
>>  If you for some reason do not wish to create a bug report,
>>  I can do it for you. You only need to provide acpidump.
> 
> Great.
> 
>>  >> and attach acpidump?
>>  >
>>  > I'll see if I can get acpidump output - in which state do you want it?
>>  > Right after boot on the broken kernel?
>>  acpidump output does not change over time, you could get it even with some other kernel.
>>
>>
> 
> Attached is the acpidump output run under 2.6.23-rc3 + with reverted
> 37f9b4c7c612fcbeb8fb6faddaef4ccdb5350145
> (IOW - this is a working configuration).
Thanks, you've got round 10100 bug number.

Please check if the following patch on top of Linus git tree helps.

Regards,
Alex 

> 
> HTH,
> MST
> 


[-- Attachment #2: ec-x.patch --]
[-- Type: text/x-patch, Size: 1694 bytes --]

ACPI: EC: fix regression

From: Alexey Starikovskiy <astarikovskiy@suse.de>


---

 drivers/acpi/ec.c |   18 +++++++++++-------
 1 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index caf873c..d6f9956 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -129,7 +129,8 @@ static struct acpi_ec {
 	struct mutex lock;
 	wait_queue_head_t wait;
 	struct list_head list;
-	u8 handlers_installed;
+	u8 handlers_installed:1;
+	u8 from_ecdt:1;
 } *boot_ec, *first_ec;
 
 /* --------------------------------------------------------------------------
@@ -772,16 +773,18 @@ static int acpi_ec_add(struct acpi_device *device)
 
 	/* Check for boot EC */
 	if (boot_ec) {
-		if (boot_ec->handle == device->handle) {
-			/* Pre-loaded EC from DSDT, just move pointer */
-			ec = boot_ec;
-			boot_ec = NULL;
-			goto end;
-		} else if (boot_ec->handle == ACPI_ROOT_OBJECT) {
+		if (boot_ec->from_ecdt &&
+		    (boot_ec->handle == device->handle ||
+		     boot_ec->handle == ACPI_ROOT_OBJECT)) {
 			/* ECDT-based EC, time to shut it down */
 			ec_remove_handlers(boot_ec);
 			kfree(boot_ec);
 			first_ec = boot_ec = NULL;
+		} else if (boot_ec->handle == device->handle) {
+			/* Pre-loaded EC from DSDT, just move pointer */
+			ec = boot_ec;
+			boot_ec = NULL;
+			goto end;
 		}
 	}
 
@@ -943,6 +946,7 @@ int __init acpi_ec_ecdt_probe(void)
 		boot_ec->command_addr = ecdt_ptr->control.address;
 		boot_ec->data_addr = ecdt_ptr->data.address;
 		boot_ec->gpe = ecdt_ptr->gpe;
+		boot_ec->from_ecdt = 1;
 		if (ACPI_FAILURE(acpi_get_handle(NULL, ecdt_ptr->id,
 				&boot_ec->handle))) {
 			pr_info("Failed to locate handle for boot EC\n");

  reply	other threads:[~2008-02-25 22:34 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 19:19 Michael S. Tsirkin
2008-02-25 19:42 ` Alexey Starikovskiy
2008-02-25 20:39   ` Michael S. Tsirkin
2008-02-25 20:50     ` Alexey Starikovskiy
2008-02-25 21:01       ` Michael S. Tsirkin
2008-02-25 22:33         ` Alexey Starikovskiy [this message]
2008-02-25 23:18           ` Michael S. Tsirkin
2008-02-25 19:46 ` Andrew Morton
2008-02-25 20:39   ` Michael S. Tsirkin
2008-02-25 20:45   ` Michael S. Tsirkin
2008-02-25 20:57     ` broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p) Rafael J. Wysocki
2008-02-25 21:26       ` Pavel Machek
2008-02-25 21:31         ` Michael S. Tsirkin
2008-02-25 21:50           ` Pavel Machek
2008-02-25 22:15             ` Michael S. Tsirkin
2008-02-25 22:20               ` Pavel Machek
2008-02-25 22:36                 ` Michael S. Tsirkin
2008-02-25 22:39                   ` Andrew Morton
2008-02-25 22:48                     ` Michael S. Tsirkin
2008-02-25 22:53                       ` Andrew Morton
2008-02-25 22:58                         ` Michael S. Tsirkin
2008-02-25 22:58                         ` Pavel Machek
     [not found]                           ` <20080225155550.4a020dfb.akpm@linux-foundation.org>
     [not found]                             ` <20080226000007.GB22102@atrey.karlin.mff.cuni.cz>
2008-02-26 10:11                               ` Pavel Machek
2008-02-26 17:46                                 ` Dave Jones
2008-02-26 17:59                                   ` Pavel Machek
2008-02-26 18:10                                     ` Dave Jones
2008-02-26 18:16                                       ` Pavel Machek
2008-02-26 18:22                                         ` Dave Jones
2008-02-26 21:56                                           ` Pavel Machek
2008-02-26 22:23                                             ` Dave Jones
2008-02-26 22:31                                               ` Rafael J. Wysocki
2008-02-26 22:51                                               ` Pavel Machek
2008-02-27 13:12                                             ` Matthew Garrett
2008-02-27 13:23                                               ` Rafael J. Wysocki
2008-02-27 15:51                                                 ` Stefan Seyfried
2008-02-27 15:55                                                   ` Matthew Garrett
2008-02-26 18:56                                         ` Andrew Morton
2008-02-26 20:09                                           ` Len Brown
2008-02-26 23:31                                           ` Ray Lee
2008-02-27  0:12                                             ` Rafael J. Wysocki
2008-02-25 21:32         ` Jeff Garzik
2008-02-25 22:21           ` Pavel Machek
2008-02-26  8:54   ` new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p Klaus S. Madsen
2008-02-26 21:32     ` Klaus S. Madsen
2008-02-26 21:44       ` Jiri Kosina
2008-02-27 22:13         ` Klaus S. Madsen
2008-02-27 23:20           ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C34246.2020705@suse.de \
    --to=astarikovskiy@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.s.tsirkin@gmail.com \
    --cc=rjw@sisk.pl \
    --subject='Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).