LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: linux-kernel@vger.kernel.org,
	Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Ralf Baechle <ralf@linux-mips.org>
Subject: Re: 2.6.25-rc3: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
Date: Tue, 26 Feb 2008 13:28:51 +0100	[thread overview]
Message-ID: <47C40603.8060908@trash.net> (raw)
In-Reply-To: <20080226122100.GB22699@deprecation.cyrius.com>

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Martin Michlmayr wrote:
> With 2.6.25-rc3 and a config file with
>
> CONFIG_CRYPTO_DEV_HIFN_795X=m
> CONFIG_CRYPTO_DEV_HIFN_795X_RNG=y
>
> I get the following build error on at least ARM and MIPS:
>
>   Building modules, stage 2.
>   MODPOST 759 modules
> ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
>   

Does this patch fix it?



[-- Attachment #2: x --]
[-- Type: text/plain, Size: 590 bytes --]

diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 3110bf7..92c53ce 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -825,8 +825,8 @@ static int hifn_register_rng(struct hifn_device *dev)
 	/*
 	 * We must wait at least 256 Pk_clk cycles between two reads of the rng.
 	 */
-	dev->rng_wait_time	= DIV_ROUND_UP(NSEC_PER_SEC, dev->pk_clk_freq) *
-				  256;
+	dev->rng_wait_time	= DIV_ROUND_UP((unsigned int)NSEC_PER_SEC,
+					       dev->pk_clk_freq) * 256;
 
 	dev->rng.name		= dev->name;
 	dev->rng.data_present	= hifn_rng_data_present,

  reply	other threads:[~2008-02-26 12:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 12:21 Martin Michlmayr
2008-02-26 12:28 ` Patrick McHardy [this message]
2008-02-26 13:39   ` Martin Michlmayr
2008-02-26 15:34 ` [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit division Adrian Bunk
2008-02-26 17:20   ` Martin Michlmayr
2008-02-26 18:52   ` Evgeniy Polyakov
2008-02-27  0:04     ` Andrew Morton
2008-02-27  6:22       ` Adrian Bunk
2008-02-27  6:47         ` Andrew Morton
2008-02-28  8:02           ` Adrian Bunk
2008-02-27 15:59       ` Evgeniy Polyakov
2008-02-27  3:46 ` 2.6.25-rc3: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined! David Rientjes
2008-02-27 11:29   ` Patrick McHardy
2008-02-28 19:40   ` Andrew Morton
2008-02-27 14:53 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C40603.8060908@trash.net \
    --to=kaber@trash.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=tbm@cyrius.com \
    --subject='Re: 2.6.25-rc3: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined'\!'' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).