LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Goodwin <markgw@sgi.com>
To: xfs-masters@oss.sgi.com
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Christoph Hellwig <hch@lst.de>,
	xfs@oss.sgi.com, johannes@sipsolutions.net,
	linux-kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [xfs-masters] Re: filesystem corruption on xfs after	2.6.25-rc1 (bisected, powerpc related?)
Date: Wed, 27 Feb 2008 07:59:35 +1100	[thread overview]
Message-ID: <47C47DB7.60102@sgi.com> (raw)
In-Reply-To: <47C47127.7040700@sandeen.net>


Eric Sandeen wrote:
> Gaudenz Steinlin wrote:
>> On Tue, Feb 26, 2008 at 01:13:56AM +0100, Rafael J. Wysocki wrote:
>>> On Tuesday, 26 of February 2008, Christoph Hellwig wrote:
>>>> On Tue, Feb 26, 2008 at 12:52:56AM +0100, Rafael J. Wysocki wrote:
>>>>>> I'm not suggesting a partial revert; I just wonder which part of the
>>>>>> change is causing the problem, as part of the debugging process.
>> I debuged this a bit further by testing the 4 changed functions
>> individually. The problem only occurs with the new version of
>> xfs_lowbit64.
>
> FWIW, Dave & I did some testing/debugging on 32-bit powerpc, and it is
> indeed only xfs_lowbit64 which is doing the wrong thing on that arch,
> because generic find_next_bit is doing the wrong thing on big-endian
> 32-bit systems, for sizes > 32 bits, near as I can tell.
>
> Rather than reverting it all, I think just changing xfs_lowbit64 back to:
> ...

Thanks Eric (and Dave), we'll look at your proposed fix. But for now,
the bit ops cleanup patch has been fully reverted, see Lachlan's earlier
mail and git pull request.

We're also expanding our internal h/w test matrix to include some
additional platforms to avoid this kind of thing in the future.

Cheers
-- Mark

      reply	other threads:[~2008-02-26 21:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 11:23 Gaudenz Steinlin
2008-02-25 11:34 ` Johannes Berg
2008-02-25 18:15 ` [xfs-masters] " Eric Sandeen
2008-02-25 23:42   ` Rafael J. Wysocki
2008-02-25 23:48     ` Eric Sandeen
2008-02-25 23:52       ` Rafael J. Wysocki
2008-02-25 23:57         ` [xfs-masters] " Christoph Hellwig
2008-02-26  0:13           ` Rafael J. Wysocki
2008-02-26  7:34             ` Gaudenz Steinlin
2008-02-26 11:44             ` Gaudenz Steinlin
2008-02-26 18:11               ` Johannes Berg
2008-02-28 14:40                 ` Eric Sandeen
2008-02-26 20:05               ` Eric Sandeen
2008-02-26 20:59                 ` Mark Goodwin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C47DB7.60102@sgi.com \
    --to=markgw@sgi.com \
    --cc=hch@lst.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=xfs-masters@oss.sgi.com \
    --cc=xfs@oss.sgi.com \
    --subject='Re: [xfs-masters] Re: filesystem corruption on xfs after	2.6.25-rc1 (bisected, powerpc related?)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).