LKML Archive on
help / color / mirror / Atom feed
From: Robert Hancock <>
To: Kuan Luo <>
Cc: Jeff Garzik <>,
	linux-kernel <>,
	Tejun Heo <>, Peer Chen <>,
	Allen Martin <>
Subject: Re: [PATCH] sata_nv: fix nmi intr or system hanging in rhel4u6 adma.
Date: Tue, 26 Feb 2008 23:24:17 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Kuan Luo wrote:
> Jeff wrote:
>> robert worte:
>>> This is basically avoiding switching into register mode, 
>> right? I don't 
>>> think this is a very good solution as the point of the 
>> tf_read function 
>>> is that it's supposed to read the taskfile provided by the drive to 
>>> diagnose the error, so not doing this isn't a good thing.
>> Agree with this analysis -- if ->tf_read() is being called, then 
>> obviously the core wants a current copy of the device's ATA registers.
>> It is not a good solution to simply avoiding returning 
>> meaningful data, 
>> because -- as Robert notes -- we need tf_read for analysis.
>> 	Jeff
> The driver got one error : "nv_adma_check_cpb: CPB 0, flags=0x11". The
> code entered ata_port_abort -> ata_qc_complete
> -> fill_result_tf->nv_adma_tf_read.
> Firstly, nv_adma_register_mode failed, showing the below messages:
> timeout waiting for ADMA IDLE, stat=0x440
> timeout waiting for ADMA LEGACY, stat=0x440
> Then enter ata_tf_read function. 
> I found the system hung at tf->hob_nsect = ioread8(ioaddr->nsect_addr);
> Sometimes the screen showed "
> CPU0: Machin check Exception 0000000000000004
> Bank 4:b200000000070f0f
> kernel panic -not syncing: CPU Context corrupt.
> "
> If nv_adma_register_mode failed, the reg result should be not
> meaningful. 
> I don't know why the systm hung.

I suspect nv_adma_register_mode failing may be the key. I don't know why 
this happens. It could be the timeout needs to be longer but I've tried 
increasing it significantly without apparent effect. (Essentially it's 
waiting for the status to go to the IDLE state, and then clears the GO 
bit and waits for LEGACY to be set. In this case both waits timed out.)

  reply	other threads:[~2008-02-27  5:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26  9:24 Kuan Luo
2008-02-26 14:41 ` Robert Hancock
2008-02-26 16:28   ` Jeff Garzik
2008-02-27  4:55     ` Kuan Luo
2008-02-27  5:24       ` Robert Hancock [this message]
2008-02-28  0:24       ` Robert Hancock
2008-02-28  3:57         ` Kuan Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] sata_nv: fix nmi intr or system hanging in rhel4u6 adma.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).