LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Tejun Heo <htejun@gmail.com>,
	Linux IDE mailing list <linux-ide@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: devres and requesting resources
Date: Fri, 29 Feb 2008 07:11:16 -0500	[thread overview]
Message-ID: <47C7F664.5040102@garzik.org> (raw)
In-Reply-To: <20080229112651.5b2a7f6f@core>

Alan Cox wrote:
>> In converting to pcim_iomap_regions(), we no longer reserve /all/ 
>> regions, only the ones requested.
>>
>> This is actually a bug:  it was intentional to call 
>> pci_request_regions(), because that ensures that no other software will 
>> use our resources -- even if we are not actively using the resource in 
>> question.
> 
> That would be a bug. We should only reserve the regions we are using. It
> is possible that the other regions can be used correctly by another driver
> (consider the CS5520 or the MPIIX where the IDE is only part of one
> function of the PCI device).

Only rare PCI devices are shareable among multiple drivers.

sata_* at least intentionally used pci_request_regions() because it is 
obvious from the hardware spec that multiple regions accessed by 
multiple drivers is highly unlikely, without the driver being 
specifically coded to support such sharing.  Such sharing code is far 
beyond simple resource reservation, to avoid stepping on toes when there 
is a single MMIO region and set of interrupt clearing registers.

So reading your email it sounds like there are valid cases for both 
configurations.

Its a design choice either way, not a bug either way.

	Jeff



  reply	other threads:[~2008-02-29 12:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29  0:36 Jeff Garzik
2008-02-29 11:26 ` Alan Cox
2008-02-29 12:11   ` Jeff Garzik [this message]
2008-02-29 12:28     ` Tejun Heo
2008-02-29 14:01       ` Alan Cox
2008-02-29 14:17         ` Tejun Heo
2008-02-29 19:25           ` Jeff Garzik
2008-02-29 17:04         ` Bartlomiej Zolnierkiewicz
2008-02-29 17:04           ` Alan Cox
2008-02-29 13:55     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C7F664.5040102@garzik.org \
    --to=jeff@garzik.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: devres and requesting resources' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).