Re: devres and requesting resources

[Tejun Heo <htejun@gmail.com>]

Alan Cox wrote:
>> controller like ICH AHCIs.  ata_generic or ide generic might attach to a
>> controller which is already being driven by ahci under certain
>> configurations.
> 
> ata_generic will not nor ata_legacy both are much too smart for that. The
> legacy old IDE driver might but that probably isn't going to be fixed by
> devres and is trivial to fix in that driver (just steal the code from
> pata_legacy).

Yeah, I saw the behavior with ahci + ide generic combination.  I think
it was on SB600.  Heh... neat trick in pata_legacy().  Hmm... it's
probably better to do at generic device level and with a generic helper.

>> have different requirements can just open code pci_request_regions() and
>> pcim_iomap().  pcim_request_regions() should provide sensible default
>> behavior for common cases.
> 
> Which is arguably the current behaviour. Changing the behaviour and not
> the name is a really bad idea and will cause problems in future so don't
> do that.
>> I think the best solution is to allow duplicate request regions for
>> managed devices which is okay as we know we're holding the resource and
>> let drivers which need to reserve all regions call pci_request_regions()
>> before calling pcim_request_regions().
> 
> How about
> 
> 	pcim_request_all_regions()
> 
> for the behaviour Jeff wants, simple, direct, differently named and
> obvious what it does.

Sounds good to me.  Jeff?

-- 
tejun