LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steve Wise <swise@opengridcomputing.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jon Mason <jon@opengridcomputing.com>,
	linux-kernel@vger.kernel.org, general@lists.openfabrics.org
Subject: Re: [PATCH] iwch_create_cq off by one error
Date: Fri, 29 Feb 2008 10:49:28 -0600	[thread overview]
Message-ID: <47C83798.3090702@opengridcomputing.com> (raw)
In-Reply-To: <1204158583-22858-1-git-send-email-jon@opengridcomputing.com>

Acked-by: Steve Wise <swise@opengridcomputing.com>


Jon Mason wrote:
> The cxbg3 driver is unnecessarily decreasing the number of cq entries
> by one when creating a cq.  This will cause an error of not having as
> many cqs as requested by the user, if the user requests a power of 2
> cq length.
> 
> Thanks,
> Jon
> 
> Signed-off-by: Jon Mason <jon@opengridcomputing.com>
> ---
>  drivers/infiniband/hw/cxgb3/iwch_provider.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> index f0c7775..800ef6d 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> @@ -188,7 +188,7 @@ static struct ib_cq *iwch_create_cq(struct ib_device *ibdev, int entries, int ve
>  		return ERR_PTR(-ENOMEM);
>  	}
>  	chp->rhp = rhp;
> -	chp->ibcq.cqe = (1 << chp->cq.size_log2) - 1;
> +	chp->ibcq.cqe = 1 << chp->cq.size_log2;
>  	spin_lock_init(&chp->lock);
>  	atomic_set(&chp->refcnt, 1);
>  	init_waitqueue_head(&chp->wait);


       reply	other threads:[~2008-02-29 16:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1204158583-22858-1-git-send-email-jon@opengridcomputing.com>
2008-02-29 16:49 ` Steve Wise [this message]
2008-03-04 16:29   ` [ofa-general] " Steve Wise
2008-03-04 19:21     ` Roland Dreier
2008-03-09 20:54   ` Roland Dreier
     [not found] ` <1204158583-22858-2-git-send-email-jon@opengridcomputing.com>
2008-02-29 16:49   ` [PATCH] update max_inline_data when creating a qp Steve Wise
2008-02-29 21:53     ` [ofa-general] " Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C83798.3090702@opengridcomputing.com \
    --to=swise@opengridcomputing.com \
    --cc=general@lists.openfabrics.org \
    --cc=jon@opengridcomputing.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --subject='Re: [PATCH] iwch_create_cq off by one error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).