Re: [PATCH] iwch_create_cq off by one error

Re: [PATCH] iwch_create_cq off by one error

[Steve Wise]

Acked-by: Steve Wise <swise@opengridcomputing.com>


Jon Mason wrote:
> The cxbg3 driver is unnecessarily decreasing the number of cq entries
> by one when creating a cq.  This will cause an error of not having as
> many cqs as requested by the user, if the user requests a power of 2
> cq length.
> 
> Thanks,
> Jon
> 
> Signed-off-by: Jon Mason <jon@opengridcomputing.com>
> ---
>  drivers/infiniband/hw/cxgb3/iwch_provider.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> index f0c7775..800ef6d 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> @@ -188,7 +188,7 @@ static struct ib_cq *iwch_create_cq(struct ib_device *ibdev, int entries, int ve
>  		return ERR_PTR(-ENOMEM);
>  	}
>  	chp->rhp = rhp;
> -	chp->ibcq.cqe = (1 << chp->cq.size_log2) - 1;
> +	chp->ibcq.cqe = 1 << chp->cq.size_log2;
>  	spin_lock_init(&chp->lock);
>  	atomic_set(&chp->refcnt, 1);
>  	init_waitqueue_head(&chp->wait);

Re: [ofa-general] Re: [PATCH] iwch_create_cq off by one error

[Steve Wise]

Hey Roland,

Are you going to pull this one in?

Thanks,

Steve.


Steve Wise wrote:
> Acked-by: Steve Wise <swise@opengridcomputing.com>
> 
> 
> Jon Mason wrote:
>> The cxbg3 driver is unnecessarily decreasing the number of cq entries
>> by one when creating a cq.  This will cause an error of not having as
>> many cqs as requested by the user, if the user requests a power of 2
>> cq length.
>>
>> Thanks,
>> Jon
>>
>> Signed-off-by: Jon Mason <jon@opengridcomputing.com>
>> ---
>>  drivers/infiniband/hw/cxgb3/iwch_provider.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c 
>> b/drivers/infiniband/hw/cxgb3/iwch_provider.c
>> index f0c7775..800ef6d 100644
>> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
>> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c
>> @@ -188,7 +188,7 @@ static struct ib_cq *iwch_create_cq(struct 
>> ib_device *ibdev, int entries, int ve
>>          return ERR_PTR(-ENOMEM);
>>      }
>>      chp->rhp = rhp;
>> -    chp->ibcq.cqe = (1 << chp->cq.size_log2) - 1;
>> +    chp->ibcq.cqe = 1 << chp->cq.size_log2;
>>      spin_lock_init(&chp->lock);
>>      atomic_set(&chp->refcnt, 1);
>>      init_waitqueue_head(&chp->wait);
> 
> _______________________________________________
> general mailing list
> general@lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit 
> http://openib.org/mailman/listinfo/openib-general

Re: [ofa-general] Re: [PATCH] iwch_create_cq off by one error

[Roland Dreier]

>  Are you going to pull this one in?

Yeah... I'm on vacation for the week but I'll get it next week.

Re: [ofa-general] Re: [PATCH] iwch_create_cq off by one error

[Roland Dreier]

thanks, applied.

Re: [PATCH] update max_inline_data when creating a qp

[Steve Wise]

Acked-by: Steve Wise <swise@opengridcomputing.com>

Jon Mason wrote:
> mthca modifies the attributes passed in when creating the qp to have
> (amongst other things) the max_inline_data.  While cxgb3 does modify
> the attributes of some of the parameters, it does not modify the
> max_inline_data to be what the adapter supports.  cxgb should conform
> to the same behavior as mthca (as some user space programs are
> expecting this) and return the max_inline_data.
> 
> Signed-off-by: Jon Mason <jon@opengridcomputing.com>
> ---
>  drivers/infiniband/hw/cxgb3/iwch_provider.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> index 800ef6d..5f0c9d3 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> @@ -818,8 +818,11 @@ static struct ib_qp *iwch_create_qp(struct ib_pd *pd,
>  		kfree(qhp);
>  		return ERR_PTR(-ENOMEM);
>  	}
> +
>  	attrs->cap.max_recv_wr = rqsize - 1;
>  	attrs->cap.max_send_wr = sqsize;
> +	attrs->cap.max_inline_data = T3_MAX_INLINE;
> +
>  	qhp->rhp = rhp;
>  	qhp->attr.pd = php->pdid;
>  	qhp->attr.scq = ((struct iwch_cq *) attrs->send_cq)->cq.cqid;

Re: [ofa-general] Re: [PATCH] update max_inline_data when creating a qp

[Roland Dreier]

thanks, applied