LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jon Schindler <jkschind@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/9] /drivers/net/8390.c replaced init_module&cleanup_module with module_init&module_exit
Date: Fri, 29 Feb 2008 20:46:21 -0600	[thread overview]
Message-ID: <47C8C37D.8060808@gmail.com> (raw)
In-Reply-To: <47C8C052.2040509@gmail.com>

I've also noticed another issue, it appears that I accidentally gave PATCH 2/9 the wrong subject.  Patch 2/9
actually fixes /drivers/net/ac3200.c, while PATCH 1/9 is the one that fixes /drivers/net/8390.c.  
What's the easiest way to fix these two patches?  Do you want to just back out patches 1 & 2 and 
I can send them as part of a different patch set?  If I change the subject for PATCH 2/9, it might
be hard for others to follow this thread.

Sorry for the trouble, I'm still getting familiar the mechanics of patch submission.

Jon
Jon Schindler wrote:
> I'm sorry, ns8390_init_module should be ns8390_module_init.  I'll resend it in the next reply.
> Andrew Morton wrote:
>> On Thu, 28 Feb 2008 01:30:25 -0600
>> Jon Schindler <jkschind@gmail.com> wrote:
>>
>>> Replaced init_module and cleanup_module with static functions and module_init/module_exit.
>> I get
>>
>> drivers/net/8390.c: In function '__inittest':
>> drivers/net/8390.c:60: error: 'ns8390_init_module' undeclared (first use in this function)
>> drivers/net/8390.c:60: error: (Each undeclared identifier is reported only once
>> drivers/net/8390.c:60: error: for each function it appears in.)
>> drivers/net/8390.c: At top level:
>> drivers/net/8390.c:60: error: 'init_module' aliased to undefined symbol 'ns8390_init_module'
>>
>>
> 


      reply	other threads:[~2008-03-01  2:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28  7:30 Jon Schindler
2008-03-01  1:24 ` Andrew Morton
2008-03-01  2:32   ` Jon Schindler
2008-03-01  2:46     ` Jon Schindler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C8C37D.8060808@gmail.com \
    --to=jkschind@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    --subject='Re: [PATCH 2/9] /drivers/net/8390.c replaced init_module&cleanup_module with module_init&module_exit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).