LKML Archive on
help / color / mirror / Atom feed
From: Frank Seidel <>
To: Andrew Morton <>
	OGAWA Hirofumi <>
Subject: Re: [RFC][PATCH] fs/partitions/msdos: directly check if FAT boot sector
Date: Sat, 01 Mar 2008 10:38:39 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Andrew Morton schrieb:
> fs/partitions/msdos.c: In function 'msdos_partition':
> fs/partitions/msdos.c:446: warning: comparison is always true due to limited range of data type
> didn't you get this?

Yes, sorry, but i saw it too late after posting.

> The reason is that FAT_VALID_MEDIA() is bogus:

yes, i stated this in our bug to the complaint
(, but should have
also posted it here, sorry.

> #define FAT_VALID_MEDIA(x)      ((0xF8 <= (x) && (x) <= 0xFF) || (x) == 0xF0)
> It appears that the on-disk field which FAT_VALID_MEDIA() is designed to
> test is only 8-bit, so the comparison with 0xff is pointless.  The only
> existing caller of FAT_VALID_MEDIA() cheats by copying the value into a
> local unsigned int first.
> So I'll leave things as they are for now, but I'd ask that someone can
> confirm that we should simply remove the 0xff test from FAT_VALID_MEDIA()?

At least in my opinion it should be removed.


      reply	other threads:[~2008-03-01  9:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 12:32 Frank Seidel
2008-02-29  2:16 ` Andreas Dilger
2008-03-01  1:02 ` Andrew Morton
2008-03-01  9:38   ` Frank Seidel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [RFC][PATCH] fs/partitions/msdos: directly check if FAT boot sector' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).