LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: David Brownell <david-b@pacbell.net>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Arch Mailing List <linux-arch@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Add C99-style constructor macros for specific-sized integers
Date: Sun, 02 Mar 2008 20:50:01 -0800	[thread overview]
Message-ID: <47CB8379.5050203@zytor.com> (raw)
In-Reply-To: <200803022014.11535.david-b@pacbell.net>

David Brownell wrote:
> On Sunday 02 March 2008, Segher Boessenkool wrote:
> 
>> Do these new macros really buy anything over just writing LL in the
>> few places that 64-bit constants are used?
> 
> The original workaround was to make the offending *SEC_TO_HZ_ADJ32
> constants use "ULL" suffixes.  Certainly making the Perl script emit
> those would be less intrusive.
> 

"Less intrusive" in the sense of smaller line count for this particular 
patch, perhaps, but it makes it less obvious when reading the code 
what's going on (a size override in an entirely different file). 
Additionally, I'm hoping these kind of things can be used elsewhere; the 
C99 <inttypes.h> facilities are really quite nice once you get over the 
rather ugly look of them, and I for one definitely miss having access to 
the in the kernel.

	-hpa

  reply	other threads:[~2008-03-03  4:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-03  0:09 H. Peter Anvin
2008-03-03  0:09 ` [PATCH 2/2] Use U64_C() instead of casts in kernel/time.c H. Peter Anvin
2008-03-03  2:38 ` [PATCH 1/2] Add C99-style constructor macros for specific-sized integers Matthew Wilcox
2008-03-03  4:43   ` H. Peter Anvin
2008-03-03  6:20     ` Al Viro
2008-03-03  6:12       ` H. Peter Anvin
2008-03-03  6:32         ` Al Viro
2008-03-03  6:28           ` H. Peter Anvin
2008-03-03  3:20 ` Segher Boessenkool
2008-03-03  4:14   ` David Brownell
2008-03-03  4:50     ` H. Peter Anvin [this message]
2008-03-03  4:45   ` H. Peter Anvin
2008-03-03 20:23     ` Segher Boessenkool
2008-03-03 10:57 ` David Howells
2008-03-03 11:43   ` Russell King
2008-03-03 12:40     ` Sam Ravnborg
2008-03-03 17:03       ` H. Peter Anvin
2008-03-03 12:15   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CB8379.5050203@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=segher@kernel.crashing.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH 1/2] Add C99-style constructor macros for specific-sized integers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).