LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Greg Ungerer <gerg@snapgear.com>
Cc: torvalds@linux-foundation.org, gerg@uclinux.org,
	linux-kernel@vger.kernel.org
Subject: Re: [M68KNOMMU]: fix fec driver interrupt races
Date: Wed, 05 Mar 2008 06:33:50 -0500	[thread overview]
Message-ID: <47CE851E.4000401@garzik.org> (raw)
In-Reply-To: <200803040652.m246q1SH012800@goober>

Greg Ungerer wrote:
> The FEC driver has a common interrupt handler for all interrupt event
> types. It is raised on a number of distinct interrupt vectors.
> This handler can't be re-entered while processing an interrupt, so
> make sure all requested vectors are flagged as IRQF_DISABLED.
> 
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>

NAK -- add spinlocks to your interrupt handling like you are supposed to



  reply	other threads:[~2008-03-05 11:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04  6:52 Greg Ungerer
2008-03-05 11:33 ` Jeff Garzik [this message]
2008-03-05 22:54   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CE851E.4000401@garzik.org \
    --to=jeff@garzik.org \
    --cc=gerg@snapgear.com \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [M68KNOMMU]: fix fec driver interrupt races' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).