LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [M68KNOMMU]: fix fec driver interrupt races
Date: Thu, 06 Mar 2008 08:54:47 +1000	[thread overview]
Message-ID: <47CF24B7.7050104@snapgear.com> (raw)
In-Reply-To: <47CE851E.4000401@garzik.org>

Hi Jeff,

Jeff Garzik wrote:
> Greg Ungerer wrote:
>> The FEC driver has a common interrupt handler for all interrupt event
>> types. It is raised on a number of distinct interrupt vectors.
>> This handler can't be re-entered while processing an interrupt, so
>> make sure all requested vectors are flagged as IRQF_DISABLED.
>>
>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
> 
> NAK -- add spinlocks to your interrupt handling like you are supposed to

A better fix is to use the separate vectors, avoiding spinlocks
in most cases. But this is a simple immediate fix for 2.6.25.
The better solution is being worked on, but it needs some
reasonable testing before it is ready for inclusion, and that
won't be till post 2.6.25.

(This is a regression, fixes in the m68knommu interrupt subsystem
exposed this).

Regards
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg@snapgear.com
Secure Computing Corporation                PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

      reply	other threads:[~2008-03-05 23:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04  6:52 Greg Ungerer
2008-03-05 11:33 ` Jeff Garzik
2008-03-05 22:54   ` Greg Ungerer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CF24B7.7050104@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [M68KNOMMU]: fix fec driver interrupt races' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).