LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jarod Wilson <jwilson@redhat.com>
Cc: linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	"Kristian Høgsberg" <krh@bitplanet.net>
Subject: Re: [PATCH update] firewire: reread config ROM when device reset the bus
Date: Thu, 06 Mar 2008 00:53:52 +0100	[thread overview]
Message-ID: <47CF3290.10404@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.55f8e340ac08be4c@s5r6.in-berlin.de>

I wrote:
> I wrote:
>>   - moved from dev->dem to idr_rwsem
>>   - extended note about semaphore protection of .config_rom and
>>     .config_rom_length
>>   - secure a few more places which access the config_rom...
>>     should have covered all of them now
> 
> Hmm.  When I power the PC down there are lots of messages scrolling by
> which look somewhat like lockdep spew.  I can't reproduce this merely by
> module unloading though.  So don't put this patch into production yet.

/...a few hundreds reboots later.../

No, it is not this patch.  It is something else.  And whatever it is, it 
is already present in 2.6.25-rc3.

To reproduce it, I need to plug an SBP-2 device in and out, then shut 
the machine down (e.g. shutdown -h now, whereas shutdown -r now does not 
seem to trigger the bug).

Since it happens after all filesystems were unmounted or r/o-mounted, I 
can't capture the log output easily (perhaps with a netconsole or so) 
but it also can't do any damage at that point anymore.

It does not happen with ohci1394 + sbp2, so it is obviously located in 
the firewire stack.

I am now gradually removing debug options from the kernel to see which 
debug facility is making the fuzz...
-- 
Stefan Richter
-=====-==--- --== --=-=
http://arcgraph.de/sr/

  reply	other threads:[~2008-03-05 23:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-02 18:35 [PATCH] firewire: replace static ROM cache by allocated cache Stefan Richter
2008-03-03  0:48 ` [PATCH] firewire: reread config ROM when device reset the bus Stefan Richter
2008-03-03 16:17   ` Kristian Høgsberg
2008-03-03 16:51     ` Stefan Richter
2008-03-03 17:28       ` Kristian Høgsberg
2008-03-03 17:58         ` Stefan Richter
2008-03-03 18:35           ` Stefan Richter
2008-03-04  5:54             ` Greg KH
2008-03-04  8:39               ` Stefan Richter
2008-03-05  0:34     ` [PATCH update] " Stefan Richter
2008-03-05  0:48       ` Stefan Richter
2008-03-05 23:53         ` Stefan Richter [this message]
2008-03-06  1:25           ` Stefan Richter
2008-03-03 20:28   ` [PATCH] " Jarod Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CF3290.10404@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=jwilson@redhat.com \
    --cc=krh@bitplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --subject='Re: [PATCH update] firewire: reread config ROM when device reset the bus' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).