LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jonas Bonn <jonas@southpole.se>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: struct pci_device_id declaration cleanups
Date: Thu, 06 Mar 2008 13:36:49 +0100	[thread overview]
Message-ID: <47CFE561.2070104@southpole.se> (raw)
In-Reply-To: <20080306122518.GB28561@infradead.org>

Christoph Hellwig wrote:
> On Thu, Mar 06, 2008 at 11:55:38AM +0100, Jonas Bonn wrote:
>> This set of patches applies the macro DECLARE_PCI_DEVICE_TABLE to the 
>> declarations of struct pci_device_id in several network drivers.  The drivers
>> build cleanly with these patches (without any new warnings) on both x86 and 
>> PowerPC.
> 
> Why would we want this macro?  It looks slightly ugly at least..
> 
> 

Basically because the alternative would be along the lines of:

static const struct pci_device_id fst_pci_dev_id[] __devinitconst = {

...and this was deemed to be even uglier when I first brought this up a 
while back.

/Jonas


      reply	other threads:[~2008-03-06 12:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 10:55 Jonas Bonn
2008-03-06 10:55 ` [PATCH] net: use DECLARE_PCI_DEVICE_TABLE Jonas Bonn
2008-03-06 10:55   ` Jonas Bonn
2008-03-06 10:55     ` Jonas Bonn
2008-03-06 10:55       ` Jonas Bonn
2008-03-06 10:55         ` Jonas Bonn
2008-03-06 10:55           ` Jonas Bonn
2008-03-06 10:55             ` Jonas Bonn
2008-03-06 10:55               ` Jonas Bonn
2008-03-06 10:55                 ` Jonas Bonn
2008-03-06 23:41   ` Andrew Morton
2008-03-07  0:18     ` David Miller
2008-03-07  7:58     ` Jonas Bonn
2008-03-06 12:25 ` struct pci_device_id declaration cleanups Christoph Hellwig
2008-03-06 12:36   ` Jonas Bonn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CFE561.2070104@southpole.se \
    --to=jonas@southpole.se \
    --cc=hch@infradead.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: struct pci_device_id declaration cleanups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).