LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: walt <w41ter@gmail.com>
To: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <petkovbb@googlemail.com>
Subject: Re: Commit 9f10d9ee breaks CD mounting/burning
Date: Thu, 06 Mar 2008 16:21:53 -0800	[thread overview]
Message-ID: <47D08AA1.4020003@gmail.com> (raw)
In-Reply-To: <200803062235.00396.bzolnier@gmail.com>

Bartlomiej Zolnierkiewicz wrote:
> On Thursday 06 March 2008, walt wrote:
>> Hi Bartolmiej,
>>
>> For me, this commit causes the problem it's intended to fix:
>>
>> commit 9f10d9ee0ac6d79d7bc8b9a158bf4a29322d84d3
>> Author: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
>> Date:   Tue Feb 26 21:50:35 2008 +0100
>>
>>       ide-cd: fix 'ireason' handling for REQ_TYPE_ATA_PC requests


> Does the following patch help?
>
> [ Borislav, please take a look and double check that it is OK. ]
>
> From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> Subject: [PATCH] ide-cd: mark REQ_TYPE_ATA_PC write requests with REQ_RW flag
>
> It turned out that REQ_TYPE_ATA_PC write requests were not marked as such
> (the previous commit assumed them to be).
>
> Reported-by: walt<w41ter@gmail.com>
> Cc: Borislav Petkov<petkovbb@googlemail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> ---
>   drivers/ide/ide-cd_ioctl.c |    4 ++++
>   1 file changed, 4 insertions(+)
>
> Index: b/drivers/ide/ide-cd_ioctl.c
> ===================================================================
> --- a/drivers/ide/ide-cd_ioctl.c
> +++ b/drivers/ide/ide-cd_ioctl.c
> @@ -457,6 +457,10 @@ int ide_cdrom_packet(struct cdrom_device
>   	   layer. the packet must be complete, as we do not
>   	   touch it at all. */
>   	ide_cd_init_rq(drive,&req);
> +
> +	if (cgc->data_direction == CGC_DATA_WRITE)
> +		req.cmd_flags |= REQ_RW;
> +
>   	memcpy(req.cmd, cgc->cmd, CDROM_PACKET_SIZE);
>   	if (cgc->sense)
>   		memset(cgc->sense, 0, sizeof(struct request_sense));
>

It's perfect, thanks!

  reply	other threads:[~2008-03-07  0:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fqngjf$cjf$1@ger.gmane.org>
2008-03-06 21:35 ` Bartlomiej Zolnierkiewicz
2008-03-07  0:21   ` walt [this message]
2008-03-07  5:48   ` Borislav Petkov
2008-03-07 20:39     ` Bartlomiej Zolnierkiewicz
2008-03-07 21:49       ` Borislav Petkov
2008-03-07 22:45         ` Bartlomiej Zolnierkiewicz
2008-03-07 23:35           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D08AA1.4020003@gmail.com \
    --to=w41ter@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@googlemail.com \
    --subject='Re: Commit 9f10d9ee breaks CD mounting/burning' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).