LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrey Borzenkov <arvidjaar@mail.ru>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [Regression] 2.6.25-rc4-git3: Handling of audio CDs broken on pata_ali
Date: Mon, 10 Mar 2008 21:03:45 +0900	[thread overview]
Message-ID: <47D523A1.7070808@gmail.com> (raw)
In-Reply-To: <47D4E78A.10507@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

Tejun Heo wrote:
> Tejun Heo wrote:
>> Rafael J. Wysocki wrote:
>>>>> where ata1 is:
>>>>>
>>>>> scsi0 : pata_ali
>>>>> scsi1 : pata_ali
>>>> Oh, is it only with audio CDs? I am unable to use DVD on pata_ali in DMA at
>>>> all. Have you tried to disable ATAPI DMA (libata.dma=1)?
>>> Data CDs seem to work fine here.
>> * Does booting into runlevel 1, putting in an audio cd and running
>> cdparanoia give the same result?
>>
>> * Does setting module parameter libata.force to "1.00:pio4" make any
>> difference?
> 
> Oh, never mind.  I have a hunch.  I'll report back in a while.
> 

Does the attached patch fix the problem?

-- 
tejun

[-- Attachment #2: use-cmd_type-in-atapi-dma-check.patch --]
[-- Type: text/x-patch, Size: 1052 bytes --]

 drivers/ata/pata_ali.c    |    2 +-
 drivers/ata/pata_it821x.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index 7e68edf..8786455 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -295,7 +295,7 @@ static void ali_lock_sectors(struct ata_device *adev)
 static int ali_check_atapi_dma(struct ata_queued_cmd *qc)
 {
 	/* If its not a media command, its not worth it */
-	if (qc->nbytes < 2048)
+	if (atapi_cmd_type(qc->cdb[0]) == ATAPI_MISC)
 		return -EOPNOTSUPP;
 	return 0;
 }
diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
index 109ddd4..f751749 100644
--- a/drivers/ata/pata_it821x.c
+++ b/drivers/ata/pata_it821x.c
@@ -564,7 +564,7 @@ static int it821x_check_atapi_dma(struct ata_queued_cmd *qc)
 	struct it821x_dev *itdev = ap->private_data;
 
 	/* Only use dma for transfers to/from the media. */
-	if (qc->nbytes < 2048)
+	if (atapi_cmd_type(qc->cdb[0]) == ATAPI_MISC)
 		return -EOPNOTSUPP;
 
 	/* No ATAPI DMA in smart mode */

  reply	other threads:[~2008-03-10 12:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08 21:46 Rafael J. Wysocki
2008-03-09  7:38 ` Andrey Borzenkov
2008-03-09 23:12   ` Rafael J. Wysocki
2008-03-10  7:42     ` Tejun Heo
2008-03-10  7:47       ` Tejun Heo
2008-03-10 12:03         ` Tejun Heo [this message]
2008-03-10 21:36           ` Rafael J. Wysocki
2008-03-11  2:31             ` Tejun Heo
2008-03-10 16:30 ` Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D523A1.7070808@gmail.com \
    --to=htejun@gmail.com \
    --cc=arvidjaar@mail.ru \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --subject='Re: [Regression] 2.6.25-rc4-git3: Handling of audio CDs broken on pata_ali' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).