LKML Archive on
help / color / mirror / Atom feed
From: "Jan Beulich" <>
To: "Ingo Molnar" <>
Cc: <>, <>,
	"Roland McGrath" <>,
	<>, <>
Subject: Re: [PATCH] x86: fix typo(?) in step.c
Date: Mon, 10 Mar 2008 11:53:19 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

>>> Ingo Molnar <> 06.03.08 14:11 >>>
>* Roland McGrath <> wrote:
>> I know.  That completely misses the point I just made:
>>    As I said then, one of my concerns was with the low-level tweaks 
>>    not yet sufficiently baked, independent from my reservations about 
>>    the ptrace feature.  Your #if'ing out of the user ABI additions for 
>>    2.6.25 does nothing to remove the unknown new risks from all the 
>>    tweaks with fingers in the low-level arch stuff.  This is the sort 
>>    of thing I was concerned about.
>> You didn't revert the parts that ever could have caused problems for 
>> anyone except those using the new ptrace extensions, i.e. changes to 
>> step.c, context switch, whatever else was touched we've lost track of 
>> now.  I keep saying that those are not baked, 100% independent of the 
>> ptrace feature.  You don't seem to be hearing me.
>well the issue is that both regset and bts had regressions, so the 
>safest was to do the minimal step of undoing any externally visible 
>changes. Feel free to send a reverter patch for the other lowlevel bts 
>bits as well.

So, is this going to be fully reverted, or is it worth pointing out/fixing
other issues? The thing I'm recognizing right now is that
eee3af4a2c83a97fff107ddc445d9df6fded9ce4 made the writes to
DebugCtlMSR unconditional, which means any attempt to do
debugging on i[345]86 will ultimately cause the kernel to oops. All of
that stuff should really depend on CONFIG_X86_DEBUGCTLMSR...


  reply	other threads:[~2008-03-10 11:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  8:36 Jan Beulich
2008-03-05 13:41 ` Ingo Molnar
2008-03-06  7:52   ` Roland McGrath
2008-03-06 11:28     ` Ingo Molnar
2008-03-06 12:03       ` Roland McGrath
2008-03-06 13:11         ` Ingo Molnar
2008-03-10 11:53           ` Jan Beulich [this message]
2008-03-11  3:44             ` Roland McGrath
2008-03-06 11:34     ` Ingo Molnar
2008-03-06 12:16       ` Roland McGrath
2008-03-06 13:13         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] x86: fix typo(?) in step.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).