LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: kristen.c.accardi@intel.com
Cc: Alex Chiang <achiang@hp.com>, Greg KH <gregkh@suse.de>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Matthew Wilcox <matthew@wil.cx>, Gary Hade <garyhade@us.ibm.com>,
warthog19@eaglescrag.net, rick.jones2@hp.com,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/4] ACPI PCI slot detection driver
Date: Wed, 12 Mar 2008 21:59:01 +0900 [thread overview]
Message-ID: <47D7D395.4070909@jp.fujitsu.com> (raw)
In-Reply-To: <20080311163411.7ddd9267@appleyard>
Kristen Carlson Accardi wrote:
> On Tue, 11 Mar 2008 22:10:40 +0900
> Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> wrote:
>
>> Hi Alex-san,
>>
>> I tried your patches, and I have two comments. I want 1) to be fixed
>> before merge to Greg's tree (or linux-next?), at least.
>
> yes, we will not merge these patches without your ack.
>
>> 1) I checked ACPI spec again and again, but I could not find any
>> reason to add Fujitsu servers to quirks list. So I'd like you to
>> add HP servers to the quirks list. I'll send the following patches
>> followed by this e-mail.
>
> I have followed up with a question on this on another thread, so I'll
> skip to #2...
> <snip>
>
>> 2) The ACPI PCI slot detection driver would change the slot names of
>> some hotplug drivers (at least I checked shpchp and pciehp). And
>> the name of slots are depending on the order of driver loading.
>> For example, on my system which has several SHPCHP slots and
>> PCIEHP slots, the name of PCIEHP slots are changed as
>> follows. Please note that PCIEHP based slots are 0034_0027 and
>> 0032_0026, and others are SHPCHP based slots.
>>
>> - Without ACPI PCI slot detection driver
>> # ls /sys/bus/pci/slots/
>> 0009_0016 0014_0018 0019_0020 0021_0022 0034_0027
>> 0011_0017 0016_0019 0021_0021 0032_0026
>>
>> - With ACPI PCI slot detection driver
>> # ls /sys/bus/pci/slots/
>> 0009_0016 0014_0018 0019_0020 0021_0022 27
>> 0011_0017 0016_0019 0021_0021 26
>>
>> I had thought it is not a big problem before because people who
>> don't like new names would not load the PCI slot driver. But since
>> it is loaded automatically at boot time, I'm wondering that it
>> would be a problem. For example, some platform, not fujitsu,
>> depends on the old slot name to work, IIRC (Maybe Kristen knows
>> the background about it). And I don't think the fact that slot
>> names are changed depending on the order of driver loading is
>> acceptable by system management people/software, though I don't
>> have such software.
>>
>> Though I don't have any specific idea about this, folliwings might
>> be candidates.
>>
>> - Override slot names with hotplug driver's slot names
>
> I think this should be done - if the pci slot driver detects that a
> hotplug driver is controlling a slot, it should allow that driver to
> set the name of the slot.
>
Yes, it is what I thought.
But maybe we should try unifying slots names first, I think.
>> - Unify slot names among all hotplug drivers
>
> I'm not sure if we can do this, since slot name might depend on what
> spec people are implementing.
>
I'm not sure too. But I think we can unify the slot names using the
combination of chassis number and slot number among the controllers
which is based on PCI Hot-Plug spec.
>> - Stop automatic loading of ACPI PCI slot driver
>
> I think we should definitely implement this one ^^^.
>
Yes. It's the simplest workaround.
BTW, I'll be out of office tomorrow. So replying to this discussion
will be delayed. I'm sorry about that.
Thanks,
Kenji Kaneshige
next prev parent reply other threads:[~2008-03-12 13:00 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 0:23 [PATCH 0/4, v7] PCI, ACPI: Physical PCI slot objects Alex Chiang
2008-02-29 0:26 ` [PATCH 1/4] Remove path attribute from sgi_hotplug Alex Chiang
2008-03-03 18:48 ` Jesse Barnes
2008-03-03 18:54 ` Prarit Bhargava
2008-03-05 0:19 ` Alex Chiang
2008-02-29 0:27 ` [PATCH 2/4] Construct one fakephp slot per pci slot Alex Chiang
2008-02-29 0:28 ` [PATCH 3/4] Introduce pci_slot Alex Chiang
2008-03-01 5:24 ` Greg KH
2008-03-03 20:56 ` Alex Chiang
2008-03-04 5:58 ` Greg KH
2008-03-04 23:30 ` [PATCH 3/4, v8] " Alex Chiang
2008-02-29 0:29 ` [PATCH 4/4] ACPI PCI slot detection driver Alex Chiang
2008-03-01 5:25 ` Greg KH
2008-03-01 14:43 ` Matthew Wilcox
2008-03-04 5:49 ` Greg KH
2008-03-04 18:18 ` Jesse Barnes
2008-03-04 19:30 ` Greg KH
2008-03-04 20:02 ` Jesse Barnes
2008-03-04 20:12 ` Kristen Carlson Accardi
2008-03-04 23:09 ` Alex Chiang
2008-03-05 1:11 ` Kenji Kaneshige
2008-03-05 20:20 ` Alex Chiang
2008-03-05 20:34 ` Matthew Wilcox
2008-03-06 2:07 ` Kenji Kaneshige
2008-03-11 13:10 ` Kenji Kaneshige
2008-03-11 13:13 ` [PATCH 3/(3+1)] " Kenji Kaneshige
2008-03-11 13:17 ` Kenji Kaneshige
2008-03-11 13:19 ` [PATCH 4/(3+1)] Add quirks for " Kenji Kaneshige
2008-03-11 13:28 ` [PATCH 4/4] " Matthew Wilcox
2008-03-11 16:56 ` Jesse Barnes
2008-03-12 5:51 ` Kenji Kaneshige
2008-03-12 4:08 ` Kenji Kaneshige
2008-03-11 18:04 ` Kristen Carlson Accardi
2008-03-11 19:14 ` Alex Chiang
2008-03-12 11:33 ` Kenji Kaneshige
2008-03-13 3:24 ` Alex Chiang
2008-03-14 2:16 ` Gary Hade
2008-03-14 5:34 ` Kenji Kaneshige
2008-03-18 20:49 ` Alex Chiang
2008-03-12 10:50 ` Kenji Kaneshige
2008-03-11 23:34 ` Kristen Carlson Accardi
2008-03-12 12:59 ` Kenji Kaneshige [this message]
2008-03-04 22:58 ` Alex Chiang
2008-03-04 23:15 ` Greg KH
2008-03-04 23:46 ` Alex Chiang
2008-03-01 5:12 ` [PATCH 0/4, v7] PCI, ACPI: Physical PCI slot objects Greg KH
2008-03-03 23:35 ` Alex Chiang
2008-03-04 5:56 ` Greg KH
2008-03-25 4:13 [PATCH 0/4, v11] " Alex Chiang
2008-03-25 4:17 ` [PATCH 4/4] ACPI PCI slot detection driver Alex Chiang
2008-03-25 4:50 ` Kenji Kaneshige
2008-03-25 17:09 [PATCH 0/4, v12] PCI, ACPI: Physical PCI slot objects Alex Chiang
2008-03-25 17:14 ` [PATCH 4/4] ACPI PCI slot detection driver Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D7D395.4070909@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=achiang@hp.com \
--cc=garyhade@us.ibm.com \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=rick.jones2@hp.com \
--cc=warthog19@eaglescrag.net \
--subject='Re: [PATCH 4/4] ACPI PCI slot detection driver' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).