LKML Archive on
help / color / mirror / Atom feed
From: Sergei Shtylyov <>
To: Bartlomiej Zolnierkiewicz <>
Subject: Re: [PATCH 4/4] ide: constify struct ide_dma_ops
Date: Thu, 13 Mar 2008 21:44:39 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


Bartlomiej Zolnierkiewicz wrote:

> * Export ide_dma_exec_cmd() and __ide_dma_test_irq().

> * Constify struct ide_dma_ops.

> * Always set hwif->dma_ops to &sff_dma_ops in ide_setup_dma()
>   (it is later overriden by ide_init_port() if needed) and drop
>   'const struct ide_port_info *d' argument.

> While at it:

> * Rename __ide_dma_test_irq() to __ide_dma_test_irq().

    I'd have expected that you also rename __ide_dma_end() to ide_dma_end()...

> Signed-off-by: Bartlomiej Zolnierkiewicz <>

Acked-by: Sergei Shtylyov <>

MBR, Sergei

      parent reply	other threads:[~2008-03-13 18:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-09 16:02 Bartlomiej Zolnierkiewicz
2008-03-09 17:01 ` Sergei Shtylyov
2008-03-10 21:53   ` Bartlomiej Zolnierkiewicz
2008-03-13 18:44 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH 4/4] ide: constify struct ide_dma_ops' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).