From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755495AbYCMSnd (ORCPT ); Thu, 13 Mar 2008 14:43:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752940AbYCMSnY (ORCPT ); Thu, 13 Mar 2008 14:43:24 -0400 Received: from homer.mvista.com ([63.81.120.155]:35439 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752167AbYCMSnX (ORCPT ); Thu, 13 Mar 2008 14:43:23 -0400 Message-ID: <47D97617.1020907@ru.mvista.com> Date: Thu, 13 Mar 2008 21:44:39 +0300 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] ide: constify struct ide_dma_ops References: <200803091702.18521.bzolnier@gmail.com> In-Reply-To: <200803091702.18521.bzolnier@gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: > * Export ide_dma_exec_cmd() and __ide_dma_test_irq(). > * Constify struct ide_dma_ops. > * Always set hwif->dma_ops to &sff_dma_ops in ide_setup_dma() > (it is later overriden by ide_init_port() if needed) and drop > 'const struct ide_port_info *d' argument. > While at it: > * Rename __ide_dma_test_irq() to __ide_dma_test_irq(). I'd have expected that you also rename __ide_dma_end() to ide_dma_end()... > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sergei Shtylyov MBR, Sergei