LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable
@ 2008-03-15 16:05 Julia Lawall
  2008-03-15 22:16 ` Jay Cliburn
  2008-03-17 11:58 ` Jeff Garzik
  0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2008-03-15 16:05 UTC (permalink / raw)
  To: jcliburn, csnook, atl1-devel, jgarzik, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

The variable update_rx is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  <+... when != i
- i = C;
  ...+>
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
---
 drivers/net/atl1/atl1_main.c |    3 ---
 1 file changed, 3 deletions(-)

diff -u -p a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
--- a/drivers/net/atl1/atl1_main.c	2008-03-12 14:13:13.000000000 +0100
+++ b/drivers/net/atl1/atl1_main.c	2008-03-15 16:18:08.000000000 +0100
@@ -1765,15 +1765,12 @@ static irqreturn_t atl1_intr(int irq, vo
 {
 	struct atl1_adapter *adapter = netdev_priv(data);
 	u32 status;
-	u8 update_rx;
 	int max_ints = 10;
 
 	status = adapter->cmb.cmb->int_stats;
 	if (!status)
 		return IRQ_NONE;
 
-	update_rx = 0;
-
 	do {
 		/* clear CMB interrupt status at once */
 		adapter->cmb.cmb->int_stats = 0;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable
  2008-03-15 16:05 [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable Julia Lawall
@ 2008-03-15 22:16 ` Jay Cliburn
  2008-03-17 11:58 ` Jeff Garzik
  1 sibling, 0 replies; 3+ messages in thread
From: Jay Cliburn @ 2008-03-15 22:16 UTC (permalink / raw)
  To: Julia Lawall; +Cc: csnook, atl1-devel, jgarzik, linux-kernel, kernel-janitors

On Sat, 15 Mar 2008 17:05:02 +0100 (CET)
Julia Lawall <julia@diku.dk> wrote:

> From: Julia Lawall <julia@diku.dk>
> 
> The variable update_rx is initialized but never used otherwise.
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
> 
> (
> extern T i;
> |
> - T i;
>   <+... when != i
> - i = C;
>   ...+>
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>

Acked-by: Jay Cliburn <jacliburn@bellsouth.net>

> ---
>  drivers/net/atl1/atl1_main.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff -u -p a/drivers/net/atl1/atl1_main.c
> b/drivers/net/atl1/atl1_main.c ---
> a/drivers/net/atl1/atl1_main.c	2008-03-12 14:13:13.000000000
> +0100 +++ b/drivers/net/atl1/atl1_main.c	2008-03-15
> 16:18:08.000000000 +0100 @@ -1765,15 +1765,12 @@ static irqreturn_t
> atl1_intr(int irq, vo { struct atl1_adapter *adapter =
> netdev_priv(data); u32 status;
> -	u8 update_rx;
>  	int max_ints = 10;
>  
>  	status = adapter->cmb.cmb->int_stats;
>  	if (!status)
>  		return IRQ_NONE;
>  
> -	update_rx = 0;
> -
>  	do {
>  		/* clear CMB interrupt status at once */
>  		adapter->cmb.cmb->int_stats = 0;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable
  2008-03-15 16:05 [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable Julia Lawall
  2008-03-15 22:16 ` Jay Cliburn
@ 2008-03-17 11:58 ` Jeff Garzik
  1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-03-17 11:58 UTC (permalink / raw)
  To: Julia Lawall; +Cc: jcliburn, csnook, atl1-devel, linux-kernel, kernel-janitors

Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
> 
> The variable update_rx is initialized but never used otherwise.
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
> 
> (
> extern T i;
> |
> - T i;
>   <+... when != i
> - i = C;
>   ...+>
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
>  drivers/net/atl1/atl1_main.c |    3 ---
>  1 file changed, 3 deletions(-)

applied



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-03-17 11:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-15 16:05 [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable Julia Lawall
2008-03-15 22:16 ` Jay Cliburn
2008-03-17 11:58 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).