LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Carlos Aguiar <carlos.aguiar@indt.org.br> To: ext Pierre Ossman <drzeus-list@drzeus.cx> Cc: Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org Subject: [PATCH 13/18] MMC: OMAP: Check the get_cover_state function pointer if not set Date: Wed, 26 Mar 2008 16:09:38 -0400 [thread overview] Message-ID: <47EAAD82.2050708@indt.org.br> (raw) In-Reply-To: <20080324132631.1e0d2125@mjolnir.drzeus.cx> From: Kyungmin Park <kyungmin.park@samsung.com> If the get_cover_state is not set, it occurs the oops. Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/mmc/host/omap.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 9ac1066..0e7ceb0 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -236,7 +236,10 @@ static void mmc_omap_release_slot(struct mmc_omap_slot *slot) static inline int mmc_omap_cover_is_open(struct mmc_omap_slot *slot) { - return slot->pdata->get_cover_state(mmc_dev(slot->mmc), slot->id); + if (slot->pdata->get_cover_state) + return slot->pdata->get_cover_state(mmc_dev(slot->mmc), + slot->id); + return 0; } static ssize_t -- 1.5.3.GIT
next prev parent reply other threads:[~2008-03-26 20:18 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-14 19:35 [PATCH 00/18] MMC: OMAP: Sync MMC OMAP driver with mainline tree Carlos Aguiar 2008-03-24 12:26 ` Pierre Ossman 2008-03-26 20:08 ` Carlos Aguiar 2008-03-30 16:10 ` Pierre Ossman 2008-03-26 20:08 ` [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver Carlos Aguiar 2008-03-26 20:08 ` [PATCH 02/18] MMC: OMAP: Remove extra divisor increase Carlos Aguiar 2008-03-26 20:08 ` [PATCH 03/18] MMC: OMAP: Fix the BYTEBLOCK capability removal Carlos Aguiar 2008-03-26 20:08 ` [PATCH 04/18] MMC: OMAP: Remove cover switch handling to allow adding multislot support Carlos Aguiar 2008-03-26 20:08 ` [PATCH 05/18] MMC: OMAP: Introduce new multislot structure and change driver to use it Carlos Aguiar 2008-03-26 20:09 ` [PATCH 06/18] MMC: OMAP: Add back cover switch support Carlos Aguiar 2008-03-26 20:09 ` [PATCH 07/18] MMC: OMAP: New release dma and abort xfer functions Carlos Aguiar 2008-03-26 20:09 ` [PATCH 08/18] MMC: OMAP: Fix timeout calculation for MMC multislot support Carlos Aguiar 2008-03-26 20:09 ` [PATCH 09/18] MMC: OMAP: Power functions modified to " Carlos Aguiar 2008-03-26 20:09 ` [PATCH 10/18] MMC: OMAP: General cleanup for " Carlos Aguiar 2008-03-26 20:09 ` [PATCH 11/18] MMC: OMAP: Abort stuck commands Carlos Aguiar 2008-03-26 20:09 ` [PATCH 12/18] MMC: OMAP: Using setup_timer instead of init_timer Carlos Aguiar 2008-03-26 20:09 ` Carlos Aguiar [this message] 2008-03-26 20:09 ` [PATCH 14/18] MMC: OMAP: Use tasklet instead of workqueue for cover switch notification Carlos Aguiar 2008-03-26 20:09 ` [PATCH 15/18] MMC: OMAP: Move failing command abortion to workqueue Carlos Aguiar 2008-03-26 20:09 ` [PATCH 16/18] MMC: OMAP: Lazy clock shutdown Carlos Aguiar 2008-03-26 20:09 ` [PATCH 17/18] MMC: OMAP: Start new commands from work queue instead of irq Carlos Aguiar 2008-03-26 20:10 ` [PATCH 18/18] MMC: OMAP: Do not busy wait for end of command for ever Carlos Aguiar -- strict thread matches above, loose matches on Subject: below -- 2008-03-14 19:36 [PATCH 13/18] MMC: OMAP: Check the get_cover_state function pointer if not set Carlos Aguiar 2008-01-28 19:07 Carlos Aguiar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=47EAAD82.2050708@indt.org.br \ --to=carlos.aguiar@indt.org.br \ --cc=drzeus-list@drzeus.cx \ --cc=linux-kernel@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).