LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Felix Möller" <email@example.com> To: Pavel Machek <firstname.lastname@example.org> Cc: "Rafael J. Wysocki" <email@example.com>, Len Brown <firstname.lastname@example.org>, ACPI Devel Maling List <email@example.com>, Andrew Morton <firstname.lastname@example.org>, Carlos Corbacho <email@example.com>, Linus Torvalds <firstname.lastname@example.org>, LKML <email@example.com>, pm list <firstname.lastname@example.org>, Shaohua Li <email@example.com>, Felix M?ller <firstname.lastname@example.org>, Arthur Erhardt <email@example.com>, Matthew Garrett <firstname.lastname@example.org> Subject: Re: [PATCH] ACPI PM: Restore the 2.6.24 suspend ordering Date: Tue, 01 Apr 2008 16:38:34 +0200 [thread overview] Message-ID: <47F248EA.email@example.com> (raw) In-Reply-To: <20080401084523.GA25278@atrey.karlin.mff.cuni.cz> Hi, >>>>>> For the reasons outlined above, the change of the suspend ordering >>>>>> should be reverted, which is done by the patch below. >>>>> But this will break those few nvidia-based systems, no? >>>>> >>>>> this may have been a good idea in -rc1 days, but we are in -rc7 >>>>> now... and the patch is slightly big. >>>> It's quite obvious, though. >>> Yes, but breaking systems between -rc7 and final is _very_ unnice. >> Breaking systems between 2.6.24 and 2.6.25 is even worse, which is why >> I've posted this patch. >> >> IOW, we tried to fix systems that were broken with 2.6.24, but it didn't work, >> because our "fix" broke systems that were OK with 2.6.24. Solution: revert >> the "fix" and go back to the design board. That's all we can do so late in >> the release cycle, IMO. > > Well, I agree that regression from 2.6.24 is worse, but it is > _slightly_ worse... -rcs are really expected to improve... > > ...plus it no longer looks like macbook regression is caused by _PTS > ordering? I am the reporter from the original Novell Bug: https://bugzilla.novell.com/show_bug.cgi?id=374217 I just tried current git head (two hours ago) with the patch (the one from the beginning of this thread) from Rafael and without it. With the patch my MacBook does suspend without it does not. HTH Felix Möller
next prev parent reply other threads:[~2008-04-01 14:45 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-30 1:19 [PATCH] ACPI PM: Restore the 2.6.24 suspend ordering Rafael J. Wysocki 2008-03-30 11:18 ` Pavel Machek 2008-03-30 11:58 ` Rafael J. Wysocki 2008-03-30 12:28 ` Pavel Machek 2008-03-30 13:15 ` Rafael J. Wysocki 2008-04-01 8:45 ` Pavel Machek 2008-04-01 14:38 ` Felix Möller [this message] 2008-04-01 19:55 ` Rafael J. Wysocki 2008-04-02 13:00 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=47F248EA.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).