LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ian Campbell <ijc@hellion.org.uk>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCHv3 1/3] x86: use ELF format in compressed images.
Date: Sun, 06 Apr 2008 10:25:28 -0700	[thread overview]
Message-ID: <47F90788.90304@zytor.com> (raw)
In-Reply-To: <86802c440804061019t1cc0e66ejee69b5d90f052b0d@mail.gmail.com>

Yinghai Lu wrote:
> On Sun, Apr 6, 2008 at 9:38 AM, H. Peter Anvin <hpa@zytor.com> wrote:
>> Yinghai Lu wrote:
>>
>>> so will cost every bzImage extra memory copy? that could be 18M or
>>> even more big.
>>>
>>  I wouldn't worry about that.  You will typically have several copies of the
>> images during the execution of the boot loader.
> 
> i put all drivers needed in kernel.
> 1. bootloader copy bzImage (6M) to memory
> 2. arch/x86/boot/compressed/head_32.S, will copy bzImage to end of
> buffer to do uncompress on possiton.
> 3. parse_elf will copy the vmlinux (the uncompressed, that is some big, 18M)
> 
> I suggest that could have special elf header, and will only have one
> PT_LOAD, and avoid the copy, and just offset start address of
> uncompressed kernel for jump later.

Once again, I think you will have a hard time measuring the time difference.

The start address of the uncompressed kernel is defined at compile time. 
  Typically it is set based on alignment constraints in the hardware; 
for x86-32 is is normally 1 MB but for reasonably large hardware 16 MB 
is better (in fact, I have proposed making 16 MB the default.)  Recovery 
kernels are frequently compiled with completely different addresses.

With your proposal, this would no longer be possible to be a 
configurable option, which would be a major loss -- a major loss of 
functionality for a small fraction of time at bootup time (which is 
almost certainly dwarfed by all the other copying and initialization 
that happens at boot time.)

	-hpa

  reply	other threads:[~2008-04-06 17:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 20:54 [PATCHv3 0/3] x86: boot protocol updates Ian Campbell
2008-02-13 20:54 ` [PATCHv3 1/3] x86: use ELF format in compressed images Ian Campbell
2008-02-13 20:54   ` [PATCHv3 2/3] x86: add a crc32 checksum to the kernel image Ian Campbell
2008-02-13 20:55     ` [PATCHv3 3/3] x86: bump image header to version 2.08 Ian Campbell
2008-02-14 11:34   ` [PATCHv3 1/3] x86: use ELF format in compressed images Mark McLoughlin
2008-02-14 17:01     ` Ian Campbell
2008-02-14 17:37       ` Mark McLoughlin
2008-02-14 17:51         ` Ian Campbell
2008-02-14 17:57       ` Ian Campbell
2008-02-14 21:10         ` Jeremy Fitzhardinge
2008-02-14 21:14           ` H. Peter Anvin
2008-02-15  6:37             ` Jeremy Fitzhardinge
2008-02-14 18:29       ` Ian Campbell
2008-02-14 18:30       ` H. Peter Anvin
2008-04-06  7:03   ` Yinghai Lu
2008-04-06 10:22     ` Ian Campbell
2008-04-06 16:38     ` H. Peter Anvin
2008-04-06 17:19       ` Yinghai Lu
2008-04-06 17:25         ` H. Peter Anvin [this message]
2008-04-06 17:34           ` Yinghai Lu
2008-02-17 14:04 ` [PATCHv3 0/3] x86: boot protocol updates Thomas Gleixner
2008-02-19  8:16   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F90788.90304@zytor.com \
    --to=hpa@zytor.com \
    --cc=ijc@hellion.org.uk \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).