Re: [PATCH 04/13] ASoC: dt-bindings: tegra: Few more Tegra210 AHUB modules

[Sameer Pujar <spujar@nvidia.com>]

Hi Rob,

Thanks for feedback.


On 9/1/2021 1:51 AM, Rob Herring wrote:
> On Fri, Aug 27, 2021 at 03:03:50PM +0530, Sameer Pujar wrote:
>> This patch adds YAML schema for DT bindings of few AHUB modules.
>> These devices will be registered as ASoC components and bindings
>> will be used on Tegra210 and later chips. The bindings for below
>> mentioned modules are added:
>>
>>   * SFC (Sampling Frequency Converter)
>>   * MVC (Master Volume Control)
>>   * AMX (Audio Multiplexer)
>>   * ADX (Audio Demultiplexer)
>>   * Mixer
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> ---
>>   .../bindings/sound/nvidia,tegra210-adx.yaml        | 74 ++++++++++++++++++++
>>   .../bindings/sound/nvidia,tegra210-ahub.yaml       | 20 ++++++
>>   .../bindings/sound/nvidia,tegra210-amx.yaml        | 72 ++++++++++++++++++++
>>   .../bindings/sound/nvidia,tegra210-mixer.yaml      | 67 ++++++++++++++++++
>>   .../bindings/sound/nvidia,tegra210-mvc.yaml        | 79 ++++++++++++++++++++++
>>   .../bindings/sound/nvidia,tegra210-sfc.yaml        | 76 +++++++++++++++++++++
>>   6 files changed, 388 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml

[...]

>> +  16 channels and demultiplexes it into four output streams of up to 16
>> +  channels each. A byte RAM helps to form output frames by any combination
>> +  of bytes from the input frame. Its design is identical to that of byte
>> +  RAM in the AMX except that the data flow direction is reversed.
>> +
>> +maintainers:
>> +  - Jon Hunter <jonathanh@nvidia.com>
>> +  - Mohan Kumar <mkumard@nvidia.com>
>> +  - Sameer Pujar <spujar@nvidia.com>
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "^adx@[0-9a-f]*$"
>> +
>> +  compatible:
>> +    oneOf:
>> +      - const: nvidia,tegra210-adx
>> +      - items:
>> +          - enum:
>> +              - nvidia,tegra194-adx
>> +              - nvidia,tegra186-adx
>> +          - const: nvidia,tegra210-adx
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  sound-name-prefix:
> nvidia,sound-name-prefix

It is supposed to be 'sound-name-prefix' for core to parse and apply 
prefix. May be this needs to be directly referenced from 
'Documentation/devicetree/bindings/sound/name-prefix.txt' after 
converting to YAML, which can be a separate commit?


Remaining comments will be taken care in next revision.