LKML Archive on
help / color / mirror / Atom feed
From: Jeff Garzik <>
To: Denys Vlasenko <>
Subject: Re: [PATCH] sb1000.c: stop inlining largish static functions
Date: Sat, 12 Apr 2008 05:08:16 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Denys Vlasenko wrote:
> Hi Jeff,
> Can you take this patch into your net driver fixes tree?
> drivers/net/sb1000.c has lots of inlined static functions.
> Mst of them are used at initialization, wait for some
> hardware register to change (wait using yield, sleep etc),
> or do slow port-based I/O. Inlining thse "for speed" makes no sense.
> This patch removes "inline" from biggest static function
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
> Size difference for 32bit x86:
>    text    data     bss     dec     hex filename
>    6299     129       0    6428    191c linux-2.6-ALLYES/drivers/net/sb1000.o
>    5418     129       0    5547    15ab linux-2.6.inline-ALLYES/drivers/net/sb1000.o
> (I also see some other optimization opportunities,
> will test and send a patch separately).
> Signed-off-by: Denys Vlasenko <>

applied both patches

      parent reply	other threads:[~2008-04-12  9:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-30 23:02 Denys Vlasenko
2008-03-30 23:13 ` [PATCH] sb1000.c: make const arrays static Denys Vlasenko
2008-04-12  9:08 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] sb1000.c: stop inlining largish static functions' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).