LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Matti Linnanvuori <mattilinn@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1.2.32] WAN: merge driver retina
Date: Thu, 07 Aug 2008 02:31:14 -0400	[thread overview]
Message-ID: <489A96B2.4030903@pobox.com> (raw)
In-Reply-To: <ca0148c30807032339o4182fbadq370f709a28861053@mail.gmail.com>

Matti Linnanvuori wrote:
> The following patch is based on linux-next:
> http://pcidriver.googlegroups.com/web/retina-patch.txt?gda=Hj6V2UEAAAD9a223ZdyQxc6jQf5toR434ka3fTOuf9SStRjUQ9KuyGG1qiJ7UbTIup-M2XPURDRb8A7WwO6f6JZwMwSZaAwRMXXBcZFbXU7ojtsMSuO4sA
> The build error and the warnings reported by David Miller have been fixed.

The version I reviewed uses virt_to_bus(), which should not be used in 
modern drivers.  The DMA API should be used instead.

A couple months ago I created a 'retina' branch of 
jgarzik/netdev-2.6.git containing your latest code.  If you could send 
patches against that, that would be helpful in reviewing the 
improvements you make to the driver, and help us get this into the kernel.

	Jeff




  reply	other threads:[~2008-08-07  6:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-04  6:39 Matti Linnanvuori
2008-08-07  6:31 ` Jeff Garzik [this message]
     [not found]   ` <ca0148c30808072334w5d2d8216s37152621b4aa8ebf@mail.gmail.com>
     [not found]     ` <ca0148c30808120246w5c2eca09u3bfa08e3ea40cfe4@mail.gmail.com>
     [not found]       ` <48CC57EB.9010500@pobox.com>
2008-09-30  9:51         ` [patch v1.2.34] " Matti Linnanvuori
2008-10-16  9:34           ` Jeff Garzik
2008-10-16  9:35             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489A96B2.4030903@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattilinn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [patch 1.2.32] WAN: merge driver retina' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).