LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Fix debugfs_create_*'s error checking method for mips/kernel/
@ 2008-10-17 11:12 Zhaolei
2008-10-17 14:37 ` Atsushi Nemoto
2008-10-17 15:05 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: Zhaolei @ 2008-10-17 11:12 UTC (permalink / raw)
To: ralf; +Cc: linux-mips, linux-kernel
Hi,
debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
---
arch/mips/kernel/setup.c | 4 ++--
arch/mips/kernel/unaligned.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 16f8edf..4430a1f 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -601,8 +601,8 @@ static int __init debugfs_mips(void)
struct dentry *d;
d = debugfs_create_dir("mips", NULL);
- if (IS_ERR(d))
- return PTR_ERR(d);
+ if (!d)
+ return -ENOMEM;
mips_debugfs_dir = d;
return 0;
}
diff --git a/arch/mips/kernel/unaligned.c b/arch/mips/kernel/unaligned.c
index c327b21..2070966 100644
--- a/arch/mips/kernel/unaligned.c
+++ b/arch/mips/kernel/unaligned.c
@@ -560,12 +560,12 @@ static int __init debugfs_unaligned(void)
return -ENODEV;
d = debugfs_create_u32("unaligned_instructions", S_IRUGO,
mips_debugfs_dir, &unaligned_instructions);
- if (IS_ERR(d))
- return PTR_ERR(d);
+ if (!d)
+ return -ENOMEM;
d = debugfs_create_u32("unaligned_action", S_IRUGO | S_IWUSR,
mips_debugfs_dir, &unaligned_action);
- if (IS_ERR(d))
- return PTR_ERR(d);
+ if (!d)
+ return -ENOMEM;
return 0;
}
__initcall(debugfs_unaligned);
--
1.5.5.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix debugfs_create_*'s error checking method for mips/kernel/
2008-10-17 11:12 [PATCH] Fix debugfs_create_*'s error checking method for mips/kernel/ Zhaolei
@ 2008-10-17 14:37 ` Atsushi Nemoto
2008-10-17 15:05 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Atsushi Nemoto @ 2008-10-17 14:37 UTC (permalink / raw)
To: zhaolei; +Cc: ralf, linux-mips, linux-kernel
On Fri, 17 Oct 2008 19:12:35 +0800, Zhaolei <zhaolei@cn.fujitsu.com> wrote:
> debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
> when debugfs is not enabled in the kernel.
>
> Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Oh that was my fault. Thank you for fixing it.
Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix debugfs_create_*'s error checking method for mips/kernel/
2008-10-17 11:12 [PATCH] Fix debugfs_create_*'s error checking method for mips/kernel/ Zhaolei
2008-10-17 14:37 ` Atsushi Nemoto
@ 2008-10-17 15:05 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2008-10-17 15:05 UTC (permalink / raw)
To: Zhaolei; +Cc: linux-mips, linux-kernel
On Fri, Oct 17, 2008 at 07:12:35PM +0800, Zhaolei wrote:
> debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
> when debugfs is not enabled in the kernel.
Applied. Thanks,
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-17 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-17 11:12 [PATCH] Fix debugfs_create_*'s error checking method for mips/kernel/ Zhaolei
2008-10-17 14:37 ` Atsushi Nemoto
2008-10-17 15:05 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).