LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Zhaolei <zhaolei@cn.fujitsu.com>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net,
linux-usb@vger.kernel.org
Subject: [PATCH v2] Fix debugfs_create_file's error checking method for usb/gadget/
Date: Mon, 20 Oct 2008 18:53:04 +0800 [thread overview]
Message-ID: <48FC6310.7020808@cn.fujitsu.com> (raw)
In-Reply-To: <20081020034639.GB26650@kroah.com>
debugfs_create_file() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
---
drivers/usb/gadget/s3c2410_udc.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index 48f51b1..00ba06b 100644
--- a/drivers/usb/gadget/s3c2410_udc.c
+++ b/drivers/usb/gadget/s3c2410_udc.c
@@ -1894,11 +1894,8 @@ static int s3c2410_udc_probe(struct platform_device *pdev)
udc->regs_info = debugfs_create_file("registers", S_IRUGO,
s3c2410_udc_debugfs_root,
udc, &s3c2410_udc_debugfs_fops);
- if (IS_ERR(udc->regs_info)) {
- dev_warn(dev, "debugfs file creation failed %ld\n",
- PTR_ERR(udc->regs_info));
- udc->regs_info = NULL;
- }
+ if (!udc->regs_info)
+ dev_warn(dev, "debugfs file creation failed\n");
}
dev_dbg(dev, "probe ok\n");
--
1.5.5.3
prev parent reply other threads:[~2008-10-20 10:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 12:54 [PATCH] " Zhaolei
2008-10-17 15:18 ` Alan Stern
2008-10-20 1:15 ` Zhaolei
2008-10-20 1:19 ` Zhaolei
2008-10-20 3:46 ` Greg KH
2008-10-20 10:53 ` Zhaolei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FC6310.7020808@cn.fujitsu.com \
--to=zhaolei@cn.fujitsu.com \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--subject='Re: [PATCH v2] Fix debugfs_create_file'\''s error checking method for usb/gadget/' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).