LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si
@ 2008-10-21 16:15 Tim Gardner
  2008-10-21 20:43 ` Corey Minyard
  0 siblings, 1 reply; 3+ messages in thread
From: Tim Gardner @ 2008-10-21 16:15 UTC (permalink / raw)
  To: minyard; +Cc: kernel-team, linux-kernel, openipmi-developer, scott

>From 07463c240c3609c1e2fbed45f64acd5fd061ce58 Mon Sep 17 00:00:00 2001
From: Scott James Remnant <scott@canonical.com>
Date: Tue, 21 Oct 2008 15:18:36 +0100
Subject: [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si

The ipmi_devintf module contains the userspace interface for IPMI
devices, yet will not be loaded automatically with a system
interface handler driver.

Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by
the ipmi_si driver, so that userspace knows of the recommendation.

Seems like a candidate for stable kernel updates.

Cc: stable@kernel.org
Signed-off-by: Scott James Remnant <scott@ubuntu.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 drivers/char/ipmi/ipmi_devintf.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
index 64e1c16..ecaf369 100644
--- a/drivers/char/ipmi/ipmi_devintf.c
+++ b/drivers/char/ipmi/ipmi_devintf.c
@@ -957,3 +957,4 @@ module_exit(cleanup_ipmi);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Corey Minyard <minyard@mvista.com>");
 MODULE_DESCRIPTION("Linux device interface for the IPMI message handler.");
+MODULE_ALIAS("platform:ipmi_si");
-- 
1.5.6.3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si
  2008-10-21 16:15 [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si Tim Gardner
@ 2008-10-21 20:43 ` Corey Minyard
  2008-10-22  9:50   ` Scott James Remnant
  0 siblings, 1 reply; 3+ messages in thread
From: Corey Minyard @ 2008-10-21 20:43 UTC (permalink / raw)
  To: Tim Gardner; +Cc: kernel-team, linux-kernel, openipmi-developer, scott

Yes, this is certainly a good idea.  I'm not 100% sure of the string, 
but it looks reasonable.

Signed-off-by: Corey Minyard <cminyard@mvista.com>

Tim Gardner wrote:
> From 07463c240c3609c1e2fbed45f64acd5fd061ce58 Mon Sep 17 00:00:00 2001
> From: Scott James Remnant <scott@canonical.com>
> Date: Tue, 21 Oct 2008 15:18:36 +0100
> Subject: [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si
>
> The ipmi_devintf module contains the userspace interface for IPMI
> devices, yet will not be loaded automatically with a system
> interface handler driver.
>
> Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by
> the ipmi_si driver, so that userspace knows of the recommendation.
>
> Seems like a candidate for stable kernel updates.
>
> Cc: stable@kernel.org
> Signed-off-by: Scott James Remnant <scott@ubuntu.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  drivers/char/ipmi/ipmi_devintf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index 64e1c16..ecaf369 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -957,3 +957,4 @@ module_exit(cleanup_ipmi);
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Corey Minyard <minyard@mvista.com>");
>  MODULE_DESCRIPTION("Linux device interface for the IPMI message handler.");
> +MODULE_ALIAS("platform:ipmi_si");
>   


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si
  2008-10-21 20:43 ` Corey Minyard
@ 2008-10-22  9:50   ` Scott James Remnant
  0 siblings, 0 replies; 3+ messages in thread
From: Scott James Remnant @ 2008-10-22  9:50 UTC (permalink / raw)
  To: Corey Minyard; +Cc: Tim Gardner, kernel-team, linux-kernel, openipmi-developer

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

On Tue, 2008-10-21 at 15:43 -0500, Corey Minyard wrote:

> Yes, this is certainly a good idea.  I'm not 100% sure of the string, 
> but it looks reasonable.
> 
The string matches the one in the platform device created by the ipmi_si
module for each device:

UEVENT[1224021721.100748] add      /devices/platform/ipmi_si.0 (platform)
ACTION=add
DEVPATH=/devices/platform/ipmi_si.0
SUBSYSTEM=platform
DRIVER=ipmi_si
MODALIAS=platform:ipmi_si
SEQNUM=2812

You also get an "ipmi_bmc.NNNN.NN" device, with a platform:ipmi_bmc.NNNN
MODALIAS, but it wasn't clear to me what that was.

Scott
-- 
Scott James Remnant
scott@canonical.com

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-10-22 10:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-21 16:15 [PATCH v2] add MODULE_ALIAS to load ipmi_devintf with ipmi_si Tim Gardner
2008-10-21 20:43 ` Corey Minyard
2008-10-22  9:50   ` Scott James Remnant

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).